New recipe: Call endpoints from the server#3202
Conversation
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
yanthomasdev
left a comment
yanthomasdev
left a comment
There was a problem hiding this comment.
LGTM, thanks for adding this @TheOtterlord! I believe it might be a good moment for us to add the RecipeLinks component to the Data Fetching page with a link for this recipe? I'll let @sarah11918 decide on this!
sarah11918
added
improve or update documentation
sarah11918
removed
the
add new content
|
Yes! I'm looking at this now @TheOtterlord and wondering whether there might be a good place for this on the Endpoints page too, actually? Where do you think it would be good to link this from? |
There was a problem hiding this comment.
Hi @TheOtterlord! Woo! Helpful recipe here! Sorry I'm just now getting around to reviewing some of the older community contributions, after getting all the launch docs reviewed and ready!
Here are some comments below so that we can whip this one into shape. Have a read through and see what you can come up with! 🙌
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
|
Thanks! Updated the recipe to deal with these issues. I had a quick look at the endpoints page. The only places I'd think to link to it would be after the overview, or at the bottom of the page. Curious what would be better. I'm leaning to the bottom of the page. |
ElianCodes
left a comment
ElianCodes
left a comment
There was a problem hiding this comment.
The Recipe content itself, looks good to me! But I also believe it should be part of the endpoints page.
The bottom of the page seems best to me. The menu then would look something like this:
|
Sorry it took so long to get back 😅 |
sarah11918
added
the
add new content
|
OK, back to this now, and the example looks great @TheOtterlord I'm going to suggest that on the endpoints page itself, though, that this recipe go much higher. Right now, it looks like it's intended to relate to "redirects" and I think this is a much more straight ahead example than that. Maybe put it right before the note in the introduction? What do you think about that? |
|
The note in the introduction to server endpoints? |
|
Yes, I'm thinking in here, right before the note where it starts talking all about params and stuff: |
|
Sounds good. I've moved it up |
4 participants
What kind of changes does this PR include?
Description