Skip to content

Document new Redirects feature#3395

Merged
sarah11918 merged 16 commits into
mainfrom
redirects-docs
Jun 6, 2023
Merged

Document new Redirects feature#3395
sarah11918 merged 16 commits into
mainfrom
redirects-docs

Conversation

@matthewp
Copy link
Copy Markdown
Contributor

@matthewp matthewp commented Jun 1, 2023

What kind of changes does this PR include?

  • New or updated content

Description

  • Closes Redirects #3311
  • Removes redirects docs from the server-side-rendering page.
  • Updates api-reference to remove note about Astro.redirect being an SSR feature.
  • Adds a section to routing explaining the redirects configuration and how it is prioritized.

@netlify
Copy link
Copy Markdown

netlify Bot commented Jun 1, 2023 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit 1cd3561
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/647f689dc49ae00008d72e06
😎 Deploy Preview https://deploy-preview-3395--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@matthewp matthewp mentioned this pull request Jun 1, 2023
Closed
sarah11918
sarah11918 reviewed Jun 1, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! What do you think about the tweaking of making both these configured and dynamic redirects sub-headings of a Redirects section? (Which is showing up as my LAST suggestion, so scroll down there first!)

Comment thread src/content/docs/en/core-concepts/routing.mdx Outdated
Comment thread src/content/docs/en/core-concepts/routing.mdx Outdated
Comment thread src/content/docs/en/core-concepts/routing.mdx Outdated
Comment thread src/content/docs/en/core-concepts/routing.mdx Outdated
Comment thread src/content/docs/en/core-concepts/routing.mdx Outdated
@sarah11918 sarah11918 added add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) labels Jun 1, 2023
sarah11918
sarah11918 reviewed Jun 1, 2023
View reviewed changes
Comment thread src/content/docs/en/guides/cms/contentful.mdx Outdated
matthewp and others added 5 commits June 1, 2023 15:57
@matthewp
Fix more redirect links
89fc0fc
@matthewp @sarah11918
Update src/content/docs/en/core-concepts/routing.mdx
1a7ae13 
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
@matthewp @sarah11918
Update src/content/docs/en/core-concepts/routing.mdx
ce52bca 
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
@matthewp @sarah11918
Update src/content/docs/en/core-concepts/routing.mdx
76ae6dd 
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
@matthewp @sarah11918
Update src/content/docs/en/core-concepts/routing.mdx
8192759 
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
sarah11918
sarah11918 reviewed Jun 1, 2023
View reviewed changes
Comment thread src/content/docs/en/core-concepts/routing.mdx Outdated
sarah11918
sarah11918 reviewed Jun 1, 2023
View reviewed changes
Comment thread src/content/docs/en/core-concepts/routing.mdx Outdated
sarah11918
sarah11918 reviewed Jun 1, 2023
View reviewed changes
Comment thread src/content/docs/en/core-concepts/routing.mdx Outdated
@sarah11918
Copy link
Copy Markdown
Member

sarah11918 commented Jun 1, 2023

I think we're good!! It's time for Yan to find everything we missed on all the "merge on release" docs, so dev is off the clock!

yanthomasdev
yanthomasdev reviewed Jun 2, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, added two small nit suggestions!

Comment thread src/content/docs/en/core-concepts/routing.mdx Outdated
Comment thread src/content/docs/en/core-concepts/routing.mdx Outdated
sarah11918 and others added 5 commits June 6, 2023 10:45
@sarah11918 @yanthomasdev
comma obvs
1dcf040 
Co-authored-by: Yan Thomas <61414485+Yan-Thomas@users.noreply.github.com>
@sarah11918 @yanthomasdev
plural Yans
12fdca8 
Co-authored-by: Yan Thomas <61414485+Yan-Thomas@users.noreply.github.com>
@sarah11918
Merge branch 'main' into redirects-docs
e3516ea
@sarah11918
Merge branch 'main' into redirects-docs
55bff01
@sarah11918
Merge branch 'main' into redirects-docs
1cd3561
@sarah11918 sarah11918 merged commit c793420 into main Jun 6, 2023
@sarah11918 sarah11918 deleted the redirects-docs branch June 6, 2023 17:17
@sarah11918 sarah11918 added the minor-release For the next minor release; in the milestone, "merge queue" = approved for merging on release day. label Jun 22, 2023
@matthewp matthewp mentioned this pull request Jul 17, 2023
Closed
@kimulaco kimulaco mentioned this pull request Dec 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sarah11918 sarah11918 sarah11918 approved these changes

@yanthomasdev yanthomasdev yanthomasdev left review comments

Assignees

No one assigned

Labels

add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" = approved for merging on release day.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Redirects

3 participants

@matthewp @sarah11918 @yanthomasdev