Skip to content

i18n(ja): Update /guides/cms/contentful.mdx#5611

Merged
yanthomasdev merged 6 commits into
withastro:mainfrom
kimulaco:i18n-ja-update-guides-cms-contentful
Dec 7, 2023
Merged

i18n(ja): Update /guides/cms/contentful.mdx#5611
yanthomasdev merged 6 commits into
withastro:mainfrom
kimulaco:i18n-ja-update-guides-cms-contentful

Conversation

@kimulaco
Copy link
Copy Markdown
Contributor

@kimulaco kimulaco commented Dec 5, 2023

Description (required)

Related issues & labels (optional)

  • Closes #
  • Suggested label:

@vercel
Copy link
Copy Markdown

vercel Bot commented Dec 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Dec 7, 2023 4:22pm

@github-actions github-actions Bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Dec 5, 2023
Copy link
Copy Markdown
Contributor

@ryuapp ryuapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1点だけコメントさせて頂きました
お手すきの際にご確認ください

```

http://localhost:4321/posts/astro-is-amazing/にアクセスすると動的ルーティングが動作していることが分かります
http://localhost:4321/にアクセスしていずれかの投稿をクリックすると動的ルーティングが動作していることが分かります
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

全部リンク化されていたので、スペースを空けると良いと思います
元の状態もリンク化されてましたね...

Suggested change
http://localhost:4321/にアクセスしていずれかの投稿をクリックすると動的ルーティングが動作していることが分かります!
http://localhost:4321/ にアクセスしていずれかの投稿をクリックすると動的ルーティングが動作していることが分かります!

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます。修正しました。 cb94661

Copy link
Copy Markdown
Contributor

@ryuapp ryuapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🎈🎈

Copy link
Copy Markdown
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good job peeps 🚀

@yanthomasdev yanthomasdev merged commit 2e81b6a into withastro:main Dec 7, 2023
ematipico pushed a commit that referenced this pull request Jan 26, 2024
* i18n(ja): Update link hash of `/guides/cms/contentful.mdx`

* i18n(ja): Update contentful guide to reflect v10

* i18n(ja): Update pnpm command

* i18n(ja): Update to use FileTree component

* i18n(ja): Fix link

---------

Co-authored-by: Yan Thomas <61414485+Yan-Thomas@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants