Update contentful guide to reflect v10#3882
Conversation
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
| ```ts title="src/lib/contentful.ts" ins={2,4-10} | ||
| import contentful from "contentful"; | ||
| import type { Document } from "@contentful/rich-text-types"; | ||
| ```ts title="src/lib/contentful.ts" ins=", { EntryFieldTypes }" ins={3-12} |
There was a problem hiding this comment.
| ```ts title="src/lib/contentful.ts" ins=", { EntryFieldTypes }" ins={3-12} | |
| ```ts title="src/lib/contentful.ts" ins="{ EntryFieldTypes }" ins={3-12} |
Just checking that you meant to show that you needed to add the comma, too! Judgement call, I'm happy either way as long as it's intentional, and wanted to make it clear that I SAW this! 😄
There was a problem hiding this comment.
yep! this is intentional, but I'm open to feedback on this. for consistency, is it a good idea to adopt a pattern of including/excluding this?
There was a problem hiding this comment.
I'm good with this as-is for now!
I only wanted to point it out to make sure that it was known that I DID see it and I DID review it! (Because it might have looked weird on first glance to someone else.) Confirming that I approve!
sarah11918
left a comment
sarah11918
left a comment
There was a problem hiding this comment.
Thank you @TheOtterlord , this is an amazingly fast, helpful contribution for a non-trivial thing! 🙌
Just see my comment below (that you might even be able to ignore) otherwise, let's add to that merge count! 🚀 📈
2 participants
What kind of changes does this PR include?
Description