[tutorial] remove check-in to in-progress branches#4753
Conversation
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
itsmatteomanf
left a comment
itsmatteomanf
left a comment
There was a problem hiding this comment.
Looks good, but a couple of notes to maybe think about.
| ## Where are you going? | ||
|
|
||
| In this unit, you'll | ||
| In this unit, you'll: |
There was a problem hiding this comment.
I know it's what it's there already, but not sure reducing "you will" to "you'll" is the best...
There was a problem hiding this comment.
I actually changed this too at first, but a) other sections do use "you'll" liberally. (though you're right, I don't like it in such a short sentence) and b) thought it might be easier on the translators not to do too much editing here. 😆
There was a problem hiding this comment.
Yeah, I do think most languages wouldn't actually change the sentence, it's just a shortening and it's merged with other changes. It'd be way worse if it was just that change alone.
I'd change it imho, but it's not a big issue at all.
There was a problem hiding this comment.
And you did while I was typing lol 😄
delucis
left a comment
delucis
left a comment
There was a problem hiding this comment.
Giving this the conceptual sign-off once the typo @itsmatteomanf spotted is fixed. Nice work @sarah11918 — really like the “Looking ahead” heading.
Co-authored-by: Matteo Manfredi <matteo@manfredi.io>
3 participants
What kind of changes does this PR include?
Description
This removes the mentions at the beginning of each unit to finding the tutorial code at that stage. For better maintenance, we've decided to only maintain the completed, final tutorial product.
Before:
After:
