fix import meta env reference in env docs#5222
Merged
Merged
Conversation
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
at-the-vr
approved these changes
Oct 28, 2023
Member
There was a problem hiding this comment.
sounds accurate. unless VITE_ is used as a prefix, env variables are not accessible in client side link to production replacement by Vite
This was referenced Nov 2, 2023
yanthomasdev
added a commit
that referenced
this pull request
Nov 11, 2023
Update minor translation #5222 Co-authored-by: Yan Thomas <61414485+Yan-Thomas@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (required)
I ended up findings some Vite docs on how to fix this, and ended up trying a few things before realizing that this worked in dev (and assuming preview/prod as well).
Before:
Because Vite statically replaces import\u002Emeta.env, you cannot access it with dynamic keys like import\u002Emeta.env[key].After:
Because Vite statically replaces import.meta.env, you cannot access it with dynamic keys like import.meta.env[key].