Skip to content

Fix import meta env reference in configuring-astro.mdx#5258

Merged
yanthomasdev merged 2 commits into
withastro:mainfrom
liruifengv:patch-11
Nov 2, 2023
Merged

Fix import meta env reference in configuring-astro.mdx#5258
yanthomasdev merged 2 commits into
withastro:mainfrom
liruifengv:patch-11

Conversation

@liruifengv
Copy link
Copy Markdown
Member

@liruifengv liruifengv commented Nov 2, 2023

Description (required)

Fix import meta env reference in configuring-astro.mdx

Fix #4110

Related issues & labels (optional)

@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 2, 2023

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 2612358
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/65439396252eb900081a0218
😎 Deploy Preview https://deploy-preview-5258--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@liruifengv liruifengv marked this pull request as ready for review November 2, 2023 01:21
@liruifengv liruifengv changed the title Update configuring-astro.mdx Fix import meta env reference in configuring-astro.mdx Nov 2, 2023
Copy link
Copy Markdown
Member

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

Copy link
Copy Markdown
Member

@at-the-vr at-the-vr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, and I thought that \u002E is some generated hash 🤦‍♂️

Copy link
Copy Markdown
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice catch! 🙌

@yanthomasdev yanthomasdev merged commit 6254ac1 into withastro:main Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

import.meta.env incorrectly rendered in Asides

4 participants