Skip to content

[i18nIgnore] Add missing comma to guides/deploy/gitlab.mdx#5514

Merged
sarah11918 merged 3 commits into
withastro:mainfrom
kimulaco:fix-guides-deploy-gitlab-code-syntax
Nov 29, 2023
Merged

[i18nIgnore] Add missing comma to guides/deploy/gitlab.mdx#5514
sarah11918 merged 3 commits into
withastro:mainfrom
kimulaco:fix-guides-deploy-gitlab-code-syntax

Conversation

@kimulaco
Copy link
Copy Markdown
Contributor

Description (required)

Added missing comma in guides/deploy/gitlab.mdx.
Fixed the translated page as well.

Related issues & labels (optional)

  • Closes #
  • Suggested label:

@vercel
Copy link
Copy Markdown

vercel Bot commented Nov 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Nov 29, 2023 2:14pm

@github-actions github-actions Bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Nov 28, 2023
Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for spotting, and taking the time to fix these! 🙌

I'm going to update the PR title so that our translation tracker isn't triggered by updates to the non-English language pages. But happy to have this fixed! 🥳

@sarah11918 sarah11918 changed the title Add missing comma to guides/deploy/gitlab.mdx [i18nIgnore] Add missing comma to guides/deploy/gitlab.mdx Nov 29, 2023
@sarah11918 sarah11918 added code snippet update Updates a code sample: typo, outdated code etc. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! labels Nov 29, 2023
@kimulaco
Copy link
Copy Markdown
Contributor Author

@sarah11918 Thanks for the review!

@sarah11918 sarah11918 merged commit 95474f3 into withastro:main Nov 29, 2023
@kimulaco kimulaco deleted the fix-guides-deploy-gitlab-code-syntax branch November 29, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code snippet update Updates a code sample: typo, outdated code etc. i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants