Skip to content

i18n(ja): Update /guides/deploy/gitlab.mdx#5524

Merged
yanthomasdev merged 3 commits into
withastro:mainfrom
kimulaco:i18n-ja-update-guides-deploy-gitlab
Dec 1, 2023
Merged

i18n(ja): Update /guides/deploy/gitlab.mdx#5524
yanthomasdev merged 3 commits into
withastro:mainfrom
kimulaco:i18n-ja-update-guides-deploy-gitlab

Conversation

@kimulaco
Copy link
Copy Markdown
Contributor

@vercel
Copy link
Copy Markdown

vercel Bot commented Nov 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Dec 1, 2023 2:42pm

@github-actions github-actions Bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Nov 29, 2023
Copy link
Copy Markdown
Member

@morinokami morinokami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

一点削除漏れがあったためコメントしました!

@@ -25,34 +26,34 @@ i18nReady: true

export default defineConfig({
sitemap: true,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/withastro/docs/blob/main/src/content/docs/en/guides/deploy/gitlab.mdx を見た感じ、この行は不要かと思います:

Suggested change
sitemap: true,

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@morinokami ありがとうございます。
#5130 の分の移植ミスだったので修正しました。97f9cfb

Copy link
Copy Markdown
Member

@morinokami morinokami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!🚀

Copy link
Copy Markdown
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks peeps 🙌

@yanthomasdev yanthomasdev merged commit d204347 into withastro:main Dec 1, 2023
@kimulaco kimulaco deleted the i18n-ja-update-guides-deploy-gitlab branch December 1, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants