Skip to content

i18n(ja): Update ui.ts#5613

Merged
yanthomasdev merged 3 commits into
withastro:mainfrom
morinokami:i18n-ja-ui-2
Dec 7, 2023
Merged

i18n(ja): Update ui.ts#5613
yanthomasdev merged 3 commits into
withastro:mainfrom
morinokami:i18n-ja-ui-2

Conversation

@morinokami
Copy link
Copy Markdown
Member

Description (required)

Related issues & labels (optional)

  • Closes #
  • Suggested label:

@vercel
Copy link
Copy Markdown

vercel Bot commented Dec 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Dec 7, 2023 0:44am

@github-actions github-actions Bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Dec 5, 2023
Comment thread src/i18n/ja/ui.ts
Comment on lines +106 to +108
'feedback.createIssue.description': 'チームに素早く問題を報告できます。',
'feedback.sendFeedback': 'フィードバックを送信',
'feedback.sendFeedback.description': 'メッセージを直接送ります。',
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

このあたりは以下のような感じで「フィードバックする」をクリックすると表示されます:

image

Comment thread src/i18n/ja/ui.ts
Comment on lines -109 to +112
'feedback.placeholder': 'なにをお知らせしますか?',
'feedback.placeholder': '伝えたいことは何ですか?',
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ここは今回の変更とは関係ありませんが、ちょっと違和感があったためわかりやすく変えてみました:

image

Comment thread src/i18n/ja/ui.ts Outdated
Comment on lines +131 to +133
// Starlight banner
'starlight.title': '自分のドキュメントを作りたいですか?',
'starlight.description': 'このテンプレートを使って始めましょう。',
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

右下の領域に表示される内容です。英語のように二行に押し込みたかったですが、意味を維持しつつとなると難しかったため、三行を許容するという選択をしました:

image

Copy link
Copy Markdown
Contributor

@kimulaco kimulaco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Copy Markdown
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks peeps 🙌

@yanthomasdev yanthomasdev merged commit 0ba074f into withastro:main Dec 7, 2023
ematipico pushed a commit that referenced this pull request Jan 26, 2024
* i18n(ja): Update ui.ts

* Rerun build

---------

Co-authored-by: Yan Thomas <61414485+Yan-Thomas@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants