I18n(ja) update images.mdx by yusasa16 · Pull Request #5840 · withastro/docs

yusasa16 · 2023-12-19T16:34:24Z

Description (required)

Update images.mdx
- b91953c

Related issues & labels (optional)

Closes #
Suggested label:

translate

vercel · 2023-12-19T16:34:29Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs	✅ Ready (Inspect)	Visit Preview		Dec 24, 2023 0:36am

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
docs-i18n	⬜️ Ignored (Inspect)	Visit Preview		Dec 24, 2023 0:36am

astrobot-houston · 2023-12-19T16:34:57Z

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

Our GitHub bots will run to check your changes.
If they spot any broken links you will see some error messages on this PR.
Don’t hesitate to ask any questions if you’re not sure what these mean!
In a few minutes, you’ll be able to see a preview of your changes on Netlify 🥳
One or more of our maintainers will take a look and may ask you to make changes.
We try to be responsive, but don’t worry if this takes a few days.

morinokami · 2023-12-20T14:49:47Z

@yusasa16 Thank you for the update! I have one question: according to the source change history, there are more changes than just b91953c. Do you plan to handle these in this PR?

yusasa16 · 2023-12-20T15:36:07Z

@morinokami Thank you for reviewing!
I wasn't aware of those changes, so i didn't plan that.
Should I include those changes in this PR?
If it is better, I can add commits :)

sarah11918 · 2023-12-20T16:53:47Z

Hi @yusasa16 ! Yes, if you are able to make those changes here, that would be very helpful!

It's still OK if you don't, so you can choose and tell me your decision!

sarah11918 · 2023-12-20T16:59:10Z

There has been one more PR made! 😄

Line 628 can also be updated here, according to this PR #5857

yusasa16 · 2023-12-21T15:34:28Z

@sarah11918 Okay! I'll do that👍
I will submit again on this weekend.
There is one question. Should I convert to draft this PR?
Actually, this is the first time to send PR to Open Source Project, so I want to know manner.

sarah11918 · 2023-12-21T15:52:20Z

Hi @yusasa16 ! Yes, you can choose to convert to draft so that the other Japanese translators know that it is not completely ready for review! (It is not required, but it can be a good way to communicate to others what the status is.)

I am very happy this is your first contribution to open-source! Thank you for choosing to help us! 🙌

yusasa16 · 2023-12-21T16:01:20Z

@sarah11918 Thanks! I've just converted.
After completing, I'll make this PR back status to open👍

yusasa16 · 2023-12-23T16:43:01Z

@morinokami @sarah11918
It’s completed! Could you review again?

morinokami

@yusasa16 色々と変更が積み重なっており大変だったと思いますが、全体的に上手く訳せていると思いました！ありがとうございます🙏

いくつか主に細かい点について Suggestions を残したので、問題なければ取り込んでいただき、終わったら再度自分に Assign をお願いします。

Co-authored-by: Shinya Fujino <shf0811@gmail.com>

yusasa16 · 2023-12-24T08:04:56Z

@morinokami 細かく見ていただきありがとうございます！
今回追加いただいたSuggestionsについては、全て確認して取り込ませていただきました🙇

morinokami

対応ありがとうございました、LGTM!!

yanthomasdev

LGTM! Great work peeps! And welcome to Team Docs @yusasa16 🙌

* i18n(ja): Update /guides/images.mdx * i18n(ja): Update /guides/images.mdx translate * i18n(ja): Update /guides/images.mdx * Update src/content/docs/ja/guides/images.mdx Co-authored-by: Shinya Fujino <shf0811@gmail.com> * Update src/content/docs/ja/guides/images.mdx Co-authored-by: Shinya Fujino <shf0811@gmail.com> * Update src/content/docs/ja/guides/images.mdx Co-authored-by: Shinya Fujino <shf0811@gmail.com> * Update src/content/docs/ja/guides/images.mdx Co-authored-by: Shinya Fujino <shf0811@gmail.com> * Update src/content/docs/ja/guides/images.mdx Co-authored-by: Shinya Fujino <shf0811@gmail.com> * Update src/content/docs/ja/guides/images.mdx Co-authored-by: Shinya Fujino <shf0811@gmail.com> * Update src/content/docs/ja/guides/images.mdx Co-authored-by: Shinya Fujino <shf0811@gmail.com> * Update src/content/docs/ja/guides/images.mdx Co-authored-by: Shinya Fujino <shf0811@gmail.com> --------- Co-authored-by: Yan Thomas <61414485+Yan-Thomas@users.noreply.github.com> Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca> Co-authored-by: Shinya Fujino <shf0811@gmail.com>

yusasa16 added 2 commits December 19, 2023 01:18

i18n(ja): Update /guides/images.mdx

c330fa5

i18n(ja): Update /guides/images.mdx

d068cb4

translate

vercel Bot had a problem deploying to Preview – docs-i18n December 19, 2023 16:34 Failure

github-actions Bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Dec 19, 2023

vercel Bot deployed to Preview – docs December 19, 2023 16:41 View deployment

Merge branch 'main' into i18n-ja-update-guides-images

b42c60a

vercel Bot deployed to Preview – docs December 19, 2023 17:36 View deployment

yusasa16 marked this pull request as draft December 21, 2023 15:55

i18n(ja): Update /guides/images.mdx

53d1e22

vercel Bot deployed to Preview – docs December 23, 2023 16:38 View deployment

yusasa16 marked this pull request as ready for review December 23, 2023 16:40

Merge branch 'main' into i18n-ja-update-guides-images

5a6d726

vercel Bot deployed to Preview – docs December 23, 2023 17:27 View deployment

morinokami reviewed Dec 24, 2023

View reviewed changes

yusasa16 and others added 6 commits December 24, 2023 17:00

Update src/content/docs/ja/guides/images.mdx

785ca80

Co-authored-by: Shinya Fujino <shf0811@gmail.com>

Update src/content/docs/ja/guides/images.mdx

b3e1113

Co-authored-by: Shinya Fujino <shf0811@gmail.com>

Update src/content/docs/ja/guides/images.mdx

35f65cc

Co-authored-by: Shinya Fujino <shf0811@gmail.com>

Update src/content/docs/ja/guides/images.mdx

1a09120

Co-authored-by: Shinya Fujino <shf0811@gmail.com>

Update src/content/docs/ja/guides/images.mdx

2ca1f05

Co-authored-by: Shinya Fujino <shf0811@gmail.com>

Update src/content/docs/ja/guides/images.mdx

cb508e6

Co-authored-by: Shinya Fujino <shf0811@gmail.com>

yusasa16 and others added 2 commits December 24, 2023 17:02

Update src/content/docs/ja/guides/images.mdx

8e2648f

Co-authored-by: Shinya Fujino <shf0811@gmail.com>

Update src/content/docs/ja/guides/images.mdx

efc47ff

Co-authored-by: Shinya Fujino <shf0811@gmail.com>

yusasa16 requested a review from morinokami December 24, 2023 08:03

vercel Bot deployed to Preview – docs December 24, 2023 08:15 View deployment

morinokami approved these changes Dec 24, 2023

View reviewed changes

Merge branch 'main' into i18n-ja-update-guides-images

8a92a47

vercel Bot deployed to Preview – docs December 24, 2023 12:36 View deployment

yanthomasdev approved these changes Dec 24, 2023

View reviewed changes

yanthomasdev merged commit 77b7a66 into withastro:main Dec 24, 2023

Uh oh!

Conversation

yusasa16 commented Dec 19, 2023

Description (required)

Related issues & labels (optional)

Uh oh!

vercel Bot commented Dec 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

astrobot-houston commented Dec 19, 2023

Uh oh!

morinokami commented Dec 20, 2023

Uh oh!

yusasa16 commented Dec 20, 2023

Uh oh!

sarah11918 commented Dec 20, 2023

Uh oh!

sarah11918 commented Dec 20, 2023

Uh oh!

yusasa16 commented Dec 21, 2023

Uh oh!

sarah11918 commented Dec 21, 2023

Uh oh!

yusasa16 commented Dec 21, 2023

Uh oh!

yusasa16 commented Dec 23, 2023

Uh oh!

morinokami left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yusasa16 commented Dec 24, 2023

Uh oh!

morinokami left a comment

Choose a reason for hiding this comment

Uh oh!

yanthomasdev left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

vercel Bot commented Dec 19, 2023 •

edited

Loading