Skip to content

Update example to use webp instead of avif#5857

Merged
sarah11918 merged 1 commit into
mainfrom
florian-lefebvre-patch-1
Dec 20, 2023
Merged

Update example to use webp instead of avif#5857
sarah11918 merged 1 commit into
mainfrom
florian-lefebvre-patch-1

Conversation

@florian-lefebvre
Copy link
Copy Markdown
Member

Description (required)

Following a discussion from Discord, it updates the background image format to use webp instead avif because:

  • Avif is not the most standard format, with known issues on MS Edge
  • A lot of beginners use this code snippet as is so it would be better to give them a "fully working" code
  • This snippet must show we can pass a custom format. Even if webp is the default, it shows that it can be set

Related issues & labels (optional)

  • Closes N/A
  • Suggested label: code snippet update, low effort

@vercel
Copy link
Copy Markdown

vercel Bot commented Dec 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Dec 20, 2023 3:02pm
1 Ignored Deployment
Name Status Preview Updated (UTC)
docs-i18n ⬜️ Ignored (Inspect) Dec 20, 2023 3:02pm

Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I followed the discussion on Discord, so I believe Erika is already fine with the change!

@sarah11918 sarah11918 added code snippet update Updates a code sample: typo, outdated code etc. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! labels Dec 20, 2023
@sarah11918 sarah11918 merged commit 563b7d9 into main Dec 20, 2023
@sarah11918 sarah11918 deleted the florian-lefebvre-patch-1 branch December 20, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code snippet update Updates a code sample: typo, outdated code etc. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants