Skip to content

Update install-manual.mdx#6653

Merged
yanthomasdev merged 5 commits into
withastro:mainfrom
liruifengv:fix-install-manual
Jan 26, 2024
Merged

Update install-manual.mdx#6653
yanthomasdev merged 5 commits into
withastro:mainfrom
liruifengv:fix-install-manual

Conversation

@liruifengv
Copy link
Copy Markdown
Member

@liruifengv liruifengv commented Jan 26, 2024

Description (required)

Update install-manual.mdx

Related issues & labels (optional)

  • Closes #
  • Suggested label:

@vercel
Copy link
Copy Markdown

vercel Bot commented Jan 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Jan 26, 2024 3:49pm

Copy link
Copy Markdown
Member

@at-the-vr at-the-vr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will it be a good thing to specify max-width so that the button is not stretched out ? This can clash with other translated buttons in different files so maybe keep it specific to this case(manual.mdx) only

Instance Button Look
Old Docs image
New Docs image

Comment thread src/content/docs/en/install/manual.mdx Outdated
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
@sarah11918
Copy link
Copy Markdown
Member

Just chiming in that we probably want to rework some text here:

Do this if you prefer not to use the CLI tool.
Prefer to use the CLI tool???

😆

image

Comment thread src/content/docs/en/install/manual.mdx Outdated
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you for making this way better. 💜

@sarah11918 sarah11918 added improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! labels Jan 26, 2024
@sarah11918
Copy link
Copy Markdown
Member

sarah11918 commented Jan 26, 2024

This one needs:

Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com>
Co-authored-by: Chris Swithinbank <357379+delucis@users.noreply.github.com>
Co-authored-by: Atharva <88548999+at-the-vr@users.noreply.github.com>

Copy link
Copy Markdown
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yanthomasdev yanthomasdev merged commit cfdf506 into withastro:main Jan 26, 2024
@liruifengv liruifengv deleted the fix-install-manual branch January 30, 2024 08:02
dreyfus92 added a commit that referenced this pull request Jan 31, 2024
* Update add-content-collections.mdx

Just for Lunaria

* Update 2.mdx

Update with PR #6558

* Update 1.mdx

Update with PR #6571

* Just for lunaria Update 3.mdx

Update with PR 6544 for lunaria

* Update error-reference.mdx

With PR #6623

* Update astro-glob-no-match.mdx

Update with PR #6623

* Create i18n-not-enabled.mdx

* Add i18n-not-enabled.mdx

With PR #6623

* Create missing-index-for-internationalization.mdx

* Add missing-index-for-internationalization.mdx

With PR #6623

* Update manual.mdx

With PR #6653

* Update prefetch.mdx

Update with PR #6573

* Update tailwind.mdx

Update with PR #6662

* Update alpinejs.mdx

Update with #6534

* Update src/content/docs/fr/install/manual.mdx

Co-authored-by: Thomas Bonnet <thomasbnt@protonmail.com>

* Update src/content/docs/fr/guides/integrations-guide/alpinejs.mdx

Co-authored-by: Thomas Bonnet <thomasbnt@protonmail.com>

* Update src/content/docs/fr/reference/errors/missing-index-for-internationalization.mdx

Co-authored-by: voxel!() <voxelmc@hotmail.com>

* Update src/content/docs/fr/reference/errors/i18n-not-enabled.mdx

Co-authored-by: voxel!() <voxelmc@hotmail.com>

* Update src/content/docs/fr/reference/errors/astro-glob-no-match.mdx

Co-authored-by: voxel!() <voxelmc@hotmail.com>

---------

Co-authored-by: Thomas Bonnet <thomasbnt@protonmail.com>
Co-authored-by: voxel!() <voxelmc@hotmail.com>
Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants