Skip to content

feat: use Starlight's Tabs#8196

Merged
liruifengv merged 5 commits into
withastro:mainfrom
liruifengv:upgrade-startlight-0.22
May 21, 2024
Merged

feat: use Starlight's Tabs#8196
liruifengv merged 5 commits into
withastro:mainfrom
liruifengv:upgrade-startlight-0.22

Conversation

@liruifengv
Copy link
Copy Markdown
Member

@liruifengv liruifengv commented May 7, 2024 •
edited
Loading

Description (required)

  • Use Starlight's Tabs component

Related issues & labels (optional)

@vercel
Copy link
Copy Markdown

vercel Bot commented May 7, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview May 21, 2024 1:27am

@github-actions github-actions Bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label May 7, 2024
@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented May 7, 2024 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
de guides/typescript.mdx Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@liruifengv
Copy link
Copy Markdown
Member Author

liruifengv commented May 7, 2024

Wait for the next Starlight version ⭐

@liruifengv liruifengv marked this pull request as draft May 7, 2024 08:39
@at-the-vr
Copy link
Copy Markdown
Member

at-the-vr commented May 17, 2024

Hey liruifengv is your PR conflicting with #8322?

@delucis
Copy link
Copy Markdown
Member

delucis commented May 17, 2024

Ah, sorry, I’d forgotten about this PR when making #8322. But I think it can still be useful.

  1. We can merge Update Starlight and Astro to latest versions #8322
  2. Then we can use this PR to migrate to Starlight’s Tabs, which is super helpful!

@liruifengv
Copy link
Copy Markdown
Member Author

liruifengv commented May 18, 2024

Ah, sorry, I’d forgotten about this PR when making #8322. But I think it can still be useful.

  1. We can merge Update Starlight and Astro to latest versions #8322

  2. Then we can use this PR to migrate to Starlight’s Tabs, which is super helpful!

No problem. I will update this PR after merge #8322

@delucis
Copy link
Copy Markdown
Member

delucis commented May 18, 2024

#8322 is merged — it’s all yours @liruifengv! 🚀

@liruifengv liruifengv changed the title feat: upgrade Starlight to 0.22.2 & use Starlight's Tabs feat: use Starlight's Tabs May 20, 2024
@liruifengv liruifengv marked this pull request as ready for review May 20, 2024 02:23
TheOtterlord
TheOtterlord approved these changes May 20, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@TheOtterlord TheOtterlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested on a handful of pages, including the shared state recipe.

delucis
delucis approved these changes May 20, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fantastic and the sync feature is working well even on more complex content like the “Sharing state” recipe.

Thank you @liruifengv! 💖

@delucis delucis added the Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! label May 20, 2024
@liruifengv
Copy link
Copy Markdown
Member Author

liruifengv commented May 21, 2024

Thank y'all!

@liruifengv
Copy link
Copy Markdown
Member Author

liruifengv commented May 21, 2024

!coauthor

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 21, 2024 

Co-authored-by: Houston (Bot) <108291165+astrobot-houston@users.noreply.github.com>
Co-authored-by: Atharva <atharvapise19@gmail.com>
Co-authored-by: Chris Swithinbank <357379+delucis@users.noreply.github.com>
Co-authored-by: Reuben Tier <64310361+TheOtterlord@users.noreply.github.com>

@liruifengv liruifengv merged commit d825b1c into withastro:main May 21, 2024
@liruifengv liruifengv deleted the upgrade-startlight-0.22 branch May 21, 2024 01:38
@liruifengv
Copy link
Copy Markdown
Member Author

liruifengv commented May 21, 2024

Oh.. I got the coauthors, but I forget add them when merge. Lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@delucis delucis delucis approved these changes

@TheOtterlord TheOtterlord TheOtterlord approved these changes

Assignees

No one assigned

Labels

i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@liruifengv @astrobot-houston @at-the-vr @delucis @TheOtterlord