Skip to content

Update Starlight and Astro to latest versions#8322

Merged
delucis merged 6 commits into
mainfrom
chris/starlight-latest
May 18, 2024
Merged

Update Starlight and Astro to latest versions#8322
delucis merged 6 commits into
mainfrom
chris/starlight-latest

Conversation

@delucis
Copy link
Copy Markdown
Member

@delucis delucis commented May 17, 2024

Description (required)

  • Updates Astro to v4.8.6
  • Updates Starlight to v0.23.0
  • Removes the previous custom rehype plugin we used to optimize MDX as this is now enabled in Starlight by default
  • Removes our existing styles for <details> elements in favour of Starlight’s new built-in styles

How to review

  • Kick the tyres! Test out different pages, check to see if styles look correct and if interactive components work as expected.
  • Find places <details> are used to see if they look OK.

@delucis delucis added the site improvement Some thing that improves the website functionality - ask @delucis for help! label May 17, 2024
@vercel
Copy link
Copy Markdown

vercel Bot commented May 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 18, 2024 2:05pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs-i18n ⬜️ Ignored (Inspect) May 18, 2024 2:05pm

@sarah11918
Copy link
Copy Markdown
Member

Adding a ton of screenshots of some of our details!

image

image

image

image

image

image

image

image

image

@delucis
Copy link
Copy Markdown
Member Author

delucis commented May 17, 2024

Amazing! We might want to add some extra CSS for the <details> in the purple box case? We handle the Starlight aside colours automatically, but that one is custom.

@delucis
Copy link
Copy Markdown
Member Author

delucis commented May 17, 2024

Added a custom colour for the purple boxes so the details looks a bit better in that context:
Purple container titled “Try it yourself - Add a blog page”. An expanded details element has a pleasantly contrasting purple border to match the container colour.

Copy link
Copy Markdown
Member

@TheOtterlord TheOtterlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I love the new details

@delucis
Copy link
Copy Markdown
Member Author

delucis commented May 18, 2024

Going to merge this based on @TheOtterlord’s approval to get those speedy builds out there working for people 🫡

@delucis delucis merged commit 4db46c7 into main May 18, 2024
@delucis delucis deleted the chris/starlight-latest branch May 18, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

site improvement Some thing that improves the website functionality - ask @delucis for help!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants