Skip to content

i18n(fr): Update basics/layouts from #9335#9368

Merged
yanthomasdev merged 9 commits into
withastro:mainfrom
thomasbnt:i18n-fr-update-basics-layouts
Sep 11, 2024
Merged

i18n(fr): Update basics/layouts from #9335#9368
yanthomasdev merged 9 commits into
withastro:mainfrom
thomasbnt:i18n-fr-update-basics-layouts

Conversation

@thomasbnt
Copy link
Copy Markdown
Member

@thomasbnt thomasbnt commented Sep 9, 2024

Description (required)

Update basics/layouts from #9335

Note

At line 189, the link not working, this section was added in #9370 PR

Related issues & labels (optional)

  • Suggested label: i18n

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
@github-actions github-actions Bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Sep 9, 2024
@netlify
Copy link
Copy Markdown

netlify Bot commented Sep 9, 2024

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 6fe3d76
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/66e1b17a8e584e0008840eda
😎 Deploy Preview https://deploy-preview-9368--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Sep 9, 2024

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
fr basics/layouts.mdx Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copy link
Copy Markdown
Member

@ArmandPhilippot ArmandPhilippot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost good:

  • an optional rewording (I think you forgot to translate a part)
  • a missing change and another one l116 (I can't add a suggestion)
  • and a section to restore!

Comment thread src/content/docs/fr/basics/layouts.mdx Outdated
Comment thread src/content/docs/fr/basics/layouts.mdx Outdated
Comment thread src/content/docs/fr/basics/layouts.mdx
thomasbnt and others added 4 commits September 10, 2024 16:19
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Comment thread src/content/docs/fr/basics/layouts.mdx Outdated
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Copy link
Copy Markdown
Member

@ArmandPhilippot ArmandPhilippot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

The broken link will be fixed with #9370

Copy link
Copy Markdown
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good job!

@yanthomasdev yanthomasdev merged commit 601f953 into withastro:main Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants