Redistribute Built-in components and remove page#9888
Merged
Conversation
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
…guide material reorganized
This was referenced Nov 6, 2024
This was referenced Nov 6, 2024
ArmandPhilippot
added a commit
to ArmandPhilippot/astro-docs
that referenced
this pull request
Nov 6, 2024
ArmandPhilippot
added a commit
to ArmandPhilippot/astro-docs
that referenced
this pull request
Nov 6, 2024
ArmandPhilippot
added a commit
to ArmandPhilippot/astro-docs
that referenced
this pull request
Nov 6, 2024
thomasbnt
added a commit
to thomasbnt/docs
that referenced
this pull request
Nov 6, 2024
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
thomasbnt
added a commit
to thomasbnt/docs
that referenced
this pull request
Nov 6, 2024
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
thomasbnt
added a commit
to thomasbnt/docs
that referenced
this pull request
Nov 6, 2024
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
thomasbnt
added a commit
to thomasbnt/docs
that referenced
this pull request
Nov 6, 2024
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
yanthomasdev
added a commit
that referenced
this pull request
Nov 6, 2024
* i18n(fr): Update `guides/troubleshooting.mdx` from #9888 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * Blank line Co-authored-by: Armand Philippot <git@armand.philippot.eu> --------- Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> Co-authored-by: Armand Philippot <git@armand.philippot.eu> Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
yanthomasdev
added a commit
that referenced
this pull request
Nov 6, 2024
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
yanthomasdev
added a commit
that referenced
this pull request
Nov 6, 2024
…n-reference.mdx` (#9934) * i18n(fr): add `guides/syntax-highlighting.mdx` See #9888 * i18n(fr): update `configuration-reference.mdx` See #9888 * i18n(fr): update a link in `integrations-guide/markdoc.mdx` --------- Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com> Co-authored-by: thomasbnt <14293805+thomasbnt@users.noreply.github.com>
yanthomasdev
added a commit
that referenced
this pull request
Nov 6, 2024
* i18n(fr): Update `guides/markdown-content.mdx` from #9888 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> * blank line Co-authored-by: Armand Philippot <git@armand.philippot.eu> * blank lines Co-authored-by: Armand Philippot <git@armand.philippot.eu> * space before colon and last comment line was not translated Co-authored-by: Armand Philippot <git@armand.philippot.eu> * i18n(fr): Update `guides/v1.mdx` from #9888 Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> --------- Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com> Co-authored-by: Armand Philippot <git@armand.philippot.eu> Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
yanthomasdev
added a commit
that referenced
this pull request
Nov 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (required)
This PR removes the Built-in Components reference page entirely in favour of redistributing the components to appropriate pages in docs.
(These components were not very similar to each other, did not all require imports, and in some cases were duplicate content existing in guides already.)
In the process:
markdown.shikiConfigcontent to configuration reference rather than having that entry link to the Markdown guide (in-branch overwrite right now, until we know what we want at the source)Note: If we don't like the experiment of syntax highlighting as its own guide, this content can go back to the Markdown guide page. However, we would need to decide on a better place for the two Code and Prism components
UPDATE: The experimental changes above were well received on Talking and Doc'ing, so going with this overall structure for now!
i18n/navpages that had itFollow up: