Skip to content

Add guide of deploying static site to Deno Deploy#9949

Merged
sarah11918 merged 3 commits into
withastro:mainfrom
NanamiNakano:main
Nov 14, 2024
Merged

Add guide of deploying static site to Deno Deploy#9949
sarah11918 merged 3 commits into
withastro:mainfrom
NanamiNakano:main

Conversation

@NanamiNakano
Copy link
Copy Markdown
Contributor

@NanamiNakano NanamiNakano commented Nov 8, 2024

Description

Add guide of deploying static site to Deno Deploy.

Right now the docs only redirect to Deno Deploy's static deployment docs, missing the full guide. This PR adds missing guides.

@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 8, 2024 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 9593367
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/67363fe665fc90000875053d
😎 Deploy Preview https://deploy-preview-9949--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Nov 8, 2024

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Netlify 🥳.

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Nov 8, 2024 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/guides/deploy/deno.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@sarah11918
Copy link
Copy Markdown
Member

sarah11918 commented Nov 11, 2024

Thank you for adding this helpful content to the docs @NanamiNakano ! 🙌

We plan to review and test it this week, so we'll be taking a look at it soon!

@sarah11918 sarah11918 added add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. 3rd-party guide Community submitted CMS, deploy, backend etc. guide labels Nov 11, 2024
casungo
casungo approved these changes Nov 12, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@casungo casungo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I tested a basic deploy and everything worked.

@casungo
Copy link
Copy Markdown
Contributor

casungo commented Nov 12, 2024

Note: While I approve these changes, I believe a "re-write" of this page should be considered in the future to make it more beginner-friendly and accessible for someone like me, who is trying Deno for the first time (I had heard of it before, but didn't have a reason to install and try it). Notably, npx astro add deno installs @astrojs/deno, not @deno/astro-adapter as outlined in the manual install section, + other things like wording and content organization. Maybe after v5 ;)

sarah11918
sarah11918 approved these changes Nov 14, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this looks good @NanamiNakano ! We appreciate you coming to add this, and are happy to welcome you to Team Docs! 🥳

@sarah11918
Copy link
Copy Markdown
Member

sarah11918 commented Nov 14, 2024

Thank you for your review @casungo ! It's very helpful and yes, down the road we probably could make improvements to this page. 🙌

@sarah11918 sarah11918 added the code snippet update Updates a code sample: typo, outdated code etc. label Nov 14, 2024
@sarah11918 sarah11918 merged commit a9065e9 into withastro:main Nov 14, 2024
@jsparkdev jsparkdev mentioned this pull request Nov 15, 2024
Merged
@Nin3lee Nin3lee mentioned this pull request Nov 15, 2024
Merged
thomasbnt added a commit to thomasbnt/docs that referenced this pull request Nov 15, 2024
@thomasbnt
i18n(fr): Update guides/deploy/deno.mdx from withastro#9949
7a9b28c 
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
@thomasbnt thomasbnt mentioned this pull request Nov 15, 2024
Merged
yanthomasdev added a commit that referenced this pull request Nov 16, 2024
@thomasbnt @yanthomasdev
i18n(fr): Update guides/deploy/deno.mdx from #9949 (#10031)
0dbced9 
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
This was referenced Dec 8, 2024
Merged
Merged
yanthomasdev added a commit that referenced this pull request Dec 8, 2024
@trueberryless @yanthomasdev
feat(import): Remove ReadMore import from guides/deploy/deno.mdx caus…
ff6481d 
…e usage got removed in #9949 (#10295)

Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sarah11918 sarah11918 sarah11918 approved these changes

+1 more reviewer

@casungo casungo casungo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

3rd-party guide Community submitted CMS, deploy, backend etc. guide add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. code snippet update Updates a code sample: typo, outdated code etc.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@NanamiNakano @astrobot-houston @sarah11918 @casungo