i18n(de): update route-data.mdx#3909
Conversation
✅ Deploy Preview for astro-starlight ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
trueberryless
left a comment
There was a problem hiding this comment.
Thanks for your translation!
I found a few suggestions to help align this translation with our style guidelines. Please refer to our i18n guide for the full terminology reference.
Generated by Astro Docs i18n Reviewer 🌍
|
HiDeoo
left a comment
There was a problem hiding this comment.
Thanks for the update.
As a non-native speaker, I reviewed this PR using the Docs Translation Review Checklist and this looks great to me.
Extra feedback regarding review comments such as this one:
- As we do not accept automated/machine translations, we can obviously not use and are not interested in automated reviews. That would definitely not be fair to translators.
- I would suggest the linked tool to not interact with PRs at all and not post any comment but rather have the results visible on the tool website so people who choose to use it can check the results there.
- While the tool can be useful, right now as it's using a PAT, it looks like a user comment rather than an automated one from a bot, which can be confusing for maintainers and translators.
- We have no idea what has been reviewed and what has not. For example, the current comment says "LGTM" but some CI checks were not successful. Was only the language/grammar reviewed, was the content and potential missing content reviewed too, etc.?
- We don't know if the user was even involved in this review or if it was fully automated, which means that we cannot trust the review comment at all as we don't accept automated reviews.
Thanks for your understanding and for your work on this new translation.
|
Thanks for the feedback of my experimental tool. This really means a ton to me! After using it on one PR from Armand, another one from fkatsuhiro and this one here, I came to the same conclusion: Writing automated comments as a user feels weird and is just confusing. I built the tool with the intention to catch general rules (common mistakes), suited to languages based on the i18n guides and general ones over all languages too. I think for this goal, the tool is decent (alto ideally the rules should be created by native speakers and not AI generated), as in both examples it catches real oversights. However, I strongly agree that the automated posting to GitHub should be removed, especially approvals. The report can already be seen on the website, so this should be enough to look over it and help reviewers. 👍 Just to clarify: My translations are done by hand. The intention of the rule is to potentially catch additional mistakes, that often go unnoticed, deterministically. The rules can be viewed here if interested. |

Description
This PR updates the German translation of
reference/route-data.mdxwith the changes from #3618.It is a continuation of #3908, so please review and merge this first, then the links should also become valid.