Skip to content

i18n(de): update route-data.mdx#3909

Merged
HiDeoo merged 3 commits into
withastro:mainfrom
trueberryless:i18n/de-ref-rou-dat
May 19, 2026
Merged

i18n(de): update route-data.mdx#3909
HiDeoo merged 3 commits into
withastro:mainfrom
trueberryless:i18n/de-ref-rou-dat

Conversation

@trueberryless
Copy link
Copy Markdown
Contributor

Description

This PR updates the German translation of reference/route-data.mdx with the changes from #3618.
It is a continuation of #3908, so please review and merge this first, then the links should also become valid.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 18, 2026

Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit ec2ed80
🔍 Latest deploy log https://app.netlify.com/projects/astro-starlight/deploys/6a0c0b676744410008673632
😎 Deploy Preview https://deploy-preview-3909--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions Bot added i18n Anything to do with internationalization & translation efforts 📚 docs Documentation website changes labels May 18, 2026
@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented May 18, 2026

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
de reference/route-data.mdx Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copy link
Copy Markdown
Contributor Author

@trueberryless trueberryless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your translation!

I found a few suggestions to help align this translation with our style guidelines. Please refer to our i18n guide for the full terminology reference.

Generated by Astro Docs i18n Reviewer 🌍

Comment thread docs/src/content/docs/de/reference/route-data.mdx Outdated
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 18, 2026

⚠️ No Changeset found

Latest commit: ec2ed80

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Copy Markdown
Contributor Author

@trueberryless trueberryless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your translation!

LGTM 🎉

Generated by Astro Docs i18n Reviewer 🌍

Copy link
Copy Markdown
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update.

As a non-native speaker, I reviewed this PR using the Docs Translation Review Checklist and this looks great to me.


Extra feedback regarding review comments such as this one:

  • As we do not accept automated/machine translations, we can obviously not use and are not interested in automated reviews. That would definitely not be fair to translators.
  • I would suggest the linked tool to not interact with PRs at all and not post any comment but rather have the results visible on the tool website so people who choose to use it can check the results there.
    • While the tool can be useful, right now as it's using a PAT, it looks like a user comment rather than an automated one from a bot, which can be confusing for maintainers and translators.
    • We have no idea what has been reviewed and what has not. For example, the current comment says "LGTM" but some CI checks were not successful. Was only the language/grammar reviewed, was the content and potential missing content reviewed too, etc.?
    • We don't know if the user was even involved in this review or if it was fully automated, which means that we cannot trust the review comment at all as we don't accept automated reviews.

Thanks for your understanding and for your work on this new translation.

@HiDeoo HiDeoo merged commit 3847d1d into withastro:main May 19, 2026
16 checks passed
@trueberryless
Copy link
Copy Markdown
Contributor Author

Thanks for the feedback of my experimental tool. This really means a ton to me!

After using it on one PR from Armand, another one from fkatsuhiro and this one here, I came to the same conclusion: Writing automated comments as a user feels weird and is just confusing. I built the tool with the intention to catch general rules (common mistakes), suited to languages based on the i18n guides and general ones over all languages too. I think for this goal, the tool is decent (alto ideally the rules should be created by native speakers and not AI generated), as in both examples it catches real oversights. However, I strongly agree that the automated posting to GitHub should be removed, especially approvals. The report can already be seen on the website, so this should be enough to look over it and help reviewers. 👍

Just to clarify: My translations are done by hand. The intention of the rule is to potentially catch additional mistakes, that often go unnoticed, deterministically.

The rules can be viewed here if interested.

@trueberryless trueberryless deleted the i18n/de-ref-rou-dat branch May 19, 2026 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📚 docs Documentation website changes i18n Anything to do with internationalization & translation efforts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants