fix: update outdated links in upgrade/version-guides#189
Conversation
📝 WalkthroughWalkthroughRemoved the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/content/docs/en/guides/upgrade/version-guides/0-1-0-beta-20.mdx (1)
29-29: Remove unused link reference.The
[web-vitals-guide]reference is defined but never used in this document. Unlike the beta-19 guide where this reference was actively used, the content referencing it has been removed in beta-20. This creates unnecessary maintenance overhead.Remove line 29:
[web-vitals-guide]: /en/package-catalog/
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
src/content/docs/en/guides/upgrade/version-guides/0-1-0-beta-20.mdx(1 hunks)src/content/docs/en/guides/upgrade/version-guides/0-1-0-beta-21.mdx(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: ArmandPhilippot
Repo: withstudiocms/docs PR: 140
File: src/content/docs/fr/guides/upgrade/version-guides/0-1-0-beta-19.mdx:24-24
Timestamp: 2025-07-21T12:16:32.374Z
Learning: In the withstudiocms/docs repository, documentation URLs in the package-catalog may maintain legacy path names for stability and consistency across language versions, even when the actual package names have been updated. Always verify that corresponding files exist before flagging URLs as broken.
📚 Learning: 2025-07-21T12:16:32.374Z
Learnt from: ArmandPhilippot
Repo: withstudiocms/docs PR: 140
File: src/content/docs/fr/guides/upgrade/version-guides/0-1-0-beta-19.mdx:24-24
Timestamp: 2025-07-21T12:16:32.374Z
Learning: In the withstudiocms/docs repository, documentation URLs in the package-catalog may maintain legacy path names for stability and consistency across language versions, even when the actual package names have been updated. Always verify that corresponding files exist before flagging URLs as broken.
Applied to files:
src/content/docs/en/guides/upgrade/version-guides/0-1-0-beta-20.mdxsrc/content/docs/en/guides/upgrade/version-guides/0-1-0-beta-21.mdx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: build-and-push
- GitHub Check: Run Starlight Link Check
🔇 Additional comments (3)
src/content/docs/en/guides/upgrade/version-guides/0-1-0-beta-20.mdx (1)
32-32: LGTM - formatting change only.This appears to be a formatting-only change (likely newline at end of file) with no functional impact on the external link.
src/content/docs/en/guides/upgrade/version-guides/0-1-0-beta-21.mdx (2)
32-32: No action needed—the external link is valid and accessible.The Effect website (effect.website) is live and functioning, serving as the official documentation for the Effect TypeScript library. The reference link syntax is correct.
29-29: The link reference definition is correct and properly formatted. The target path/en/package-catalog/exists and is consistent with beta-20. The reference definition is maintained for consistency across version guides, following the established documentation pattern.
2a82086 to
041f812
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/content/docs/en/guides/upgrade/version-guides/0-1-0-beta-21.mdx (1)
31-31: Approve changes and remove unused effect-website link definition.The removal of the
web-vitals-guidelink addresses the PR objective to eliminate outdated/404 links, and the formatting adjustment (newline at EOF) follows best practices.The
effect-websitelink definition on line 31 is unused throughout the document and should be removed as dead code:{/* External Links */} [config-doc]: /en/config-reference/ [image-service]: /en/config-reference/features/#preferredimageservice [cloudinary-plugin]: /en/package-catalog/studiocms-plugins/studiocms-cloudinary-js/ -[effect-website]: https://effect.website
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
src/content/docs/en/guides/upgrade/version-guides/0-1-0-beta-20.mdx(1 hunks)src/content/docs/en/guides/upgrade/version-guides/0-1-0-beta-21.mdx(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- src/content/docs/en/guides/upgrade/version-guides/0-1-0-beta-20.mdx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Run Starlight Link Check
- GitHub Check: build-and-push
Description
There was two links targeting the
web-vitalspage which is now removed. I removed them since they are not used on these pages.Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.