Conversation
Dokploy Preview Deployment
|
📝 WalkthroughWalkthroughRemoved several Spanish StudioCMS config-reference pages and added two consolidated Spanish pages (features and locale); updated the config-reference index links accordingly. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (1)
src/content/docs/es/config-reference/features.mdx (1)
70-84: Add Type/Default bullets to thesdksection for consistency.The
sdksection lacks the Type and Default bullets that appear in all other top-level feature sections (robotsTXT,injectQuickActionsMenu,cacheConfig). This same gap exists in both the English and Spanish versions.📄 Suggested addition for `sdk`
`sdk` puede ser un booleano o un objeto que contiene la configuración de caché. Si es un booleano, por defecto se establece en `true` y se transforma en un objeto con la configuración de caché por defecto. +- **Tipo:** `boolean` | `{ cacheConfig?: boolean | { lifetime?: string } }` +- **Valor predeterminado:** `true` + ### Uso🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/content/docs/es/config-reference/features.mdx` around lines 70 - 84, Add the missing "Type" and "Default" bullet lines to the `sdk` feature docs under the "## `sdk`" heading so it matches other top-level feature sections; update both English and Spanish files where `## `sdk`` appears (the same block that shows the usage with defineStudioCMSConfig and features: { sdk: {} }) to include a "Type" bullet (e.g., "boolean | object") and a "Default" bullet (e.g., "true → {} (default cache config)") consistent with the style used in `robotsTXT`, `injectQuickActionsMenu`, and `cacheConfig`.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/content/docs/es/config-reference/features.mdx`:
- Around line 296-319: Update the `providers` description to mention both
`usernameAndPassword` and `usernameAndPasswordConfig` as configurable keys (the
text currently only names `usernameAndPassword` but the example shows
`usernameAndPasswordConfig`); edit the paragraph around `providers` so it lists
both keys and briefly notes that `usernameAndPassword` toggles the provider and
`usernameAndPasswordConfig` contains provider-specific options like
`allowUserRegistration`, keeping the existing code example unchanged.
- Line 164: Change the capitalised word "Favicon" to lowercase "favicon" in the
Spanish doc sentence that describes `faviconURL`; update the sentence that
currently reads "`faviconURL` permite al usuario sobreescribir la URL del
Favicon por defecto..." so it reads "... la URL del favicon por defecto..." to
match Spanish common noun capitalization and keep the code symbol `faviconURL`
unchanged.
In `@src/content/docs/es/config-reference/locale.mdx`:
- Around line 76-85: The MDX code block showing the studiocms.config.mjs example
(starting with ```ts and using defineStudioCMSConfig with
locale.i18n.defaultLocale) is missing its closing triple-backtick fence; add a
closing ``` after the final `})` to properly terminate the code block so the
page renders correctly.
---
Nitpick comments:
In `@src/content/docs/es/config-reference/features.mdx`:
- Around line 70-84: Add the missing "Type" and "Default" bullet lines to the
`sdk` feature docs under the "## `sdk`" heading so it matches other top-level
feature sections; update both English and Spanish files where `## `sdk`` appears
(the same block that shows the usage with defineStudioCMSConfig and features: {
sdk: {} }) to include a "Type" bullet (e.g., "boolean | object") and a "Default"
bullet (e.g., "true → {} (default cache config)") consistent with the style used
in `robotsTXT`, `injectQuickActionsMenu`, and `cacheConfig`.
There was a problem hiding this comment.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In `@src/content/docs/es/config-reference/features.mdx`:
- Around line 296-319: Update the prose for the `providers` section to mention
the companion config key `usernameAndPasswordConfig` used in `authConfig` (shown
in the example) so it matches the code sample; specifically, change the sentence
that currently only names `usernameAndPassword` to also reference
`usernameAndPasswordConfig` and its purpose (e.g., configuring
`allowUserRegistration`) so readers of `defineStudioCMSConfig` can see both keys
are configurable.
Description
Adds missing docs in
config-referenceSummary by CodeRabbit