Skip to content

i18n(ko-KR): create index.mdx#75

Merged
Adammatthiesen merged 2 commits into
withstudiocms:mainfrom
jsparkdev:index
Apr 17, 2025
Merged

i18n(ko-KR): create index.mdx#75
Adammatthiesen merged 2 commits into
withstudiocms:mainfrom
jsparkdev:index

Conversation

@jsparkdev
Copy link
Copy Markdown
Contributor

@jsparkdev jsparkdev commented Apr 17, 2025

Description

create index.mdx

Summary by CodeRabbit

  • New Features
    • Introduced a Korean-language landing page for StudioCMS documentation, featuring a hero section, welcome video, quick start guides, resource links, and a call-to-action to join the community.

@jsparkdev jsparkdev requested a review from a team as a code owner April 17, 2025 01:52
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 17, 2025

Walkthrough

A new Korean-language landing page for StudioCMS documentation has been introduced. The page includes internationalization metadata, a hero section with branding, primary action buttons, an embedded welcome video, and a grid of cards offering quick start instructions, resource links, and customization options. The page concludes with a call-to-action for joining the StudioCMS Discord community. Markdown link references are defined for consistent internal and external linking throughout the content.

Changes

File(s) Change Summary
src/content/docs/ko/index.mdx Added a new Korean documentation landing page for StudioCMS, including UI components and content.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Korean Docs Page
    participant StudioCMS Resources

    User ->> Korean Docs Page: Access landing page
    Korean Docs Page ->> User: Display hero section, action buttons
    User ->> Korean Docs Page: Clicks "Get Started" or "GitHub" button
    Korean Docs Page ->> StudioCMS Resources: Redirect or open link
    User ->> Korean Docs Page: Views embedded video, reads cards
    Korean Docs Page ->> User: Presents quick start, guides, and resource links
    User ->> Korean Docs Page: Clicks Discord CTA
    Korean Docs Page ->> StudioCMS Resources: Redirect to Discord community
Loading

Possibly related PRs

Suggested labels

i18n

Suggested reviewers

  • Adammatthiesen

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)
  • We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 36e58e5 and 6d0c716.

📒 Files selected for processing (1)
  • src/content/docs/ko/index.mdx (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/content/docs/ko/index.mdx

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@studiocms-no-reply
Copy link
Copy Markdown
Member

studiocms-no-reply commented Apr 17, 2025

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
ko/index.mdx Localization added, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (4)
src/content/docs/ko/index.mdx (4)

11-13: Localize the alt attribute for accessibility and verify image paths.

  • The alt text is in English ("StudioCMS Logo"); consider translating it to Korean (e.g., "StudioCMS 로고") to match the rest of the page.
  • Double‑check that the relative paths (../../../assets/logos/...) correctly point to your assets directory from src/content/docs/ko/index.mdx.

14-22: Use consistent action variants and enhance external link safety.

  • The second hero action (GitHub 리포지토리) currently lacks a variant (e.g., secondary), which can lead to inconsistent styling.
  • For the external GitHub link, consider adding target="_blank" and rel="noopener" to improve UX and security.

37-55: Quick start section is clear, but refine styling.

  • The shell example is helpful; ensure the fenced code block renders properly inside <SplitCard>.
  • The inline <div style="padding: 0;"> can be moved to a CSS class for better maintainability (e.g., .quick-start-details { padding: 0; }).

77-84: Refine CTA button styling.
Inline styles on <LinkButton> can be migrated to your stylesheet under the existing .discord-button class (e.g., add width: fit-content; margin: 3rem auto 0;). This keeps styling consistent and maintainable.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5e92e71 and 36e58e5.

📒 Files selected for processing (1)
  • src/content/docs/ko/index.mdx (1 hunks)
🔇 Additional comments (8)
src/content/docs/ko/index.mdx (8)

1-7: Frontmatter configuration looks good.
The i18n metadata (i18nReady: true), title, description, and layout template align with the localized landing page requirements.


24-30: Imports look correct for the MDX layout.
All necessary UI components (CardGrid, LinkButton, Youtube, Card, ListCard, SplitCard, Center) are imported after the frontmatter in accordance with Astro MDX conventions.


31-33: Hero video section is well‑structured.
The <Card> wrapper and embedded <Youtube> component provide a clear, localized welcome. The video ID looks correct, and the structure supports both light/dark themes.


47-53: Verify the environment-variables link target.
The quick start text references [환경 변수][environment-variables], but the markdown link for environment-variables may point to the same getting-started page. Please confirm that this identifier leads to the dedicated environment‑variables documentation.


57-62: ‘StudioCMS 알아보기’ links look good.
The list items (시작하기, 환경 변수, 왜 StudioCMS인가?, StudioCMS 이해하기) accurately reference the localized guides.


64-69: ‘StudioCMS 사용자 정의’ links look good.
The customization section correctly points to SDK, REST API, plugin catalog, and plugin API documentation.


73-76: Call-to-action layout is solid.
Using the <Center> component ensures the community invitation stands out, and the Korean copy reads naturally.


90-98: Review markdown link references for consistency.

  • [environment-variables] and [getting-started] currently resolve to the same path—ensure they aren’t accidentally duplicated.
  • Other references (turso, why-studiocms, etc.) align with the localized routes.

@Adammatthiesen Adammatthiesen merged commit a41ad1c into withstudiocms:main Apr 17, 2025
7 checks passed
@jsparkdev jsparkdev deleted the index branch April 17, 2025 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants