Skip to content

i18n(ko-KR): update package-catalog/ and index.mdx#97

Merged
Adammatthiesen merged 3 commits into
withstudiocms:mainfrom
jsparkdev:shorts
Apr 20, 2025
Merged

i18n(ko-KR): update package-catalog/ and index.mdx#97
Adammatthiesen merged 3 commits into
withstudiocms:mainfrom
jsparkdev:shorts

Conversation

@jsparkdev
Copy link
Copy Markdown
Contributor

@jsparkdev jsparkdev commented Apr 20, 2025

Description

Summary by CodeRabbit

  • New Features

    • Added a new badge description for "실험적" (experimental) packages in the Korean documentation, clarifying their development status.
  • Documentation

    • Updated the main welcome card on the Korean StudioCMS documentation landing page with a new title and replaced the embedded YouTube video with a native video player.
    • Improved installation instructions for several StudioCMS plugins in the Korean documentation for greater clarity and consistency.

@jsparkdev jsparkdev requested a review from a team as a code owner April 20, 2025 07:25
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 20, 2025

Walkthrough

This update modifies several Korean documentation pages for StudioCMS. The main landing page's welcome card title is changed, and its embedded YouTube video is replaced with a native HTML video element sourcing a direct MP4 file. The package catalog page adds a new badge description for experimental packages. Installation instructions for three plugin documentation pages are revised to use a more explicit package manager command and updated step descriptions, clarifying the configuration process.

Changes

File(s) Change Summary
src/content/docs/ko/index.mdx Changed welcome card title and replaced embedded YouTube video with a native HTML <video> element sourcing an MP4 file.
src/content/docs/ko/package-catalog/index.mdx Added a new badge description for "실험적" (experimental) packages, explaining their early development status.
src/content/docs/ko/package-catalog/studiocms-plugins/studiocms-blog.mdx
src/content/docs/ko/package-catalog/studiocms-plugins/studiocms-markdoc.mdx
src/content/docs/ko/package-catalog/studiocms-plugins/studiocms-mdx.mdx
Updated installation instructions to use explicit <PackageManagers> command syntax and revised step descriptions for clarity.

Possibly related PRs

  • i18n(ko-KR): create index.mdx #75: Initially created the Korean documentation landing page index.mdx with the original welcome card and YouTube embed, which this PR directly modifies.

Suggested labels

i18n

Suggested reviewers

  • Adammatthiesen

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@studiocms-no-reply
Copy link
Copy Markdown
Member

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
ko/index.mdx Localization changed, will be marked as complete.
ko/package-catalog/index.mdx Localization changed, will be marked as complete.
ko/package-catalog/studiocms-plugins/studiocms-blog.mdx Localization changed, will be marked as complete.
ko/package-catalog/studiocms-plugins/studiocms-markdoc.mdx Localization changed, will be marked as complete.
ko/package-catalog/studiocms-plugins/studiocms-mdx.mdx Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@jsparkdev jsparkdev changed the title i18n(ko-KR): update package-catalog/studiocms-plugins/ i18n(ko-KR): update package-catalog/ and index.mdx Apr 20, 2025
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
src/content/docs/ko/index.mdx (1)

31-32: Review HTML5 video implementation and clean up unused imports

The new <video> tag correctly replaces the YouTube embed, preserving autoplay, looping, muting, inline play, and preloading.

  • Consider adding controls or a text fallback for better accessibility and browser support.
  • Double‑check that the MP4 URL is CDN‑backed and reliable.
  • Since the Youtube component is no longer used, you may want to remove its import (line 25) to keep the code clean.
src/content/docs/ko/package-catalog/index.mdx (1)

14-14: Use consistent terminology and syntax.

  • The new badge description refers to "플러그인" while the surrounding badges consistently mention "패키지." Consider changing "이 플러그인은" to "이 패키지는" for consistency.
  • There's an extra space before the self-closing slash (variant="danger" />). Remove it to match the formatting of other badges (variant="danger"/>).
- <Badge text="실험적" variant="danger" /> 라벨이 있는 모든 패키지는 아직 개발 초기 단계에 있으며 언제든지 내부 구조에 큰 변화가 있을 수 있습니다. 이 플러그인은 사용 준비가 되었을 수도 있고, 아직 아닐 수도 있습니다.
+ <Badge text="실험적" variant="danger"/> 라벨이 있는 모든 패키지는 아직 개발 초기 단계에 있으며 언제든지 내부 구조에 큰 변화가 있을 수 있습니다. 이 패키지는 사용 준비가 되었을 수도 있고, 아직 아닐 수도 있습니다.
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0ea37e7 and b7c4650.

📒 Files selected for processing (5)
  • src/content/docs/ko/index.mdx (1 hunks)
  • src/content/docs/ko/package-catalog/index.mdx (1 hunks)
  • src/content/docs/ko/package-catalog/studiocms-plugins/studiocms-blog.mdx (1 hunks)
  • src/content/docs/ko/package-catalog/studiocms-plugins/studiocms-markdoc.mdx (1 hunks)
  • src/content/docs/ko/package-catalog/studiocms-plugins/studiocms-mdx.mdx (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Run Starlight Link Check
🔇 Additional comments (6)
src/content/docs/ko/package-catalog/studiocms-plugins/studiocms-markdoc.mdx (2)

24-24: Approve explicit package installation command.

The change to <PackageManagers pkg="studiocms" type='run' args='add @studiocms/markdoc' /> makes the installation step clearer and aligns with other plugin docs.


26-26: Approve generalized configuration step wording.

Updating the second step to "이제 StudioCMS 구성은 @studiocms/markdoc를 포함해야 합니다." is concise and consistent with the style used across plugin documentation.

src/content/docs/ko/package-catalog/studiocms-plugins/studiocms-blog.mdx (2)

24-24: Approve explicit package installation command.

Using <PackageManagers pkg="studiocms" type='run' args='add @studiocms/blog' /> enhances clarity and standardizes the install instructions with other plugins.


26-26: Approve generalized configuration step wording.

Changing the second step to "이제 StudioCMS 구성은 @studiocms/blog를 포함해야 합니다." is clear, succinct, and consistent across the docs.

src/content/docs/ko/package-catalog/studiocms-plugins/studiocms-mdx.mdx (2)

24-24: Approve explicit package installation command.

The <PackageManagers pkg="studiocms" type='run' args='add @studiocms/mdx' /> update clarifies the installation step and matches the pattern used for other plugins.


26-26: Approve generalized configuration step wording.

Updating to "이제 StudioCMS 구성은 @studiocms/mdx를 포함해야 합니다." maintains consistency and removes any ambiguity.

@Adammatthiesen Adammatthiesen merged commit b26f49e into withstudiocms:main Apr 20, 2025
8 checks passed
@jsparkdev jsparkdev deleted the shorts branch April 20, 2025 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants