Upgrade playground react-native's version to 0.66 by yogevbd · Pull Request #7034 · wix/react-native-navigation

yogevbd · 2021-03-15T11:53:37Z

Release Notes

ReactNative

ReactNative 0.66
Fix Warnings and deprecations.

Android

iOS

swabbass · 2021-04-11T15:12:22Z

I Think also in this upgrade we can bump a major, and drop support for old ReactNative versions in android (Flavors), we might support RN 0.63+ version at least in the android side since it's taking a lot of resources maintaining these backwards compatibility behaviours across RN versions.

@guyca wdyt?

stale · 2021-05-27T20:39:02Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

yogevbd · 2021-05-27T20:50:54Z

@swabbass we will drop support for RN versions lower than 0.64 in V8 🔥

birkir · 2021-05-29T10:37:39Z

It would make sense to use hermes on android too, right?

swabbass · 2021-05-30T09:31:11Z

It would make sense to use Hermes on android too, right?

Hey @birkir :]
The js side of RNN works with Hermes and JSC, it's up to the host app to use Hermes or other variants, we can enable it by default, but it feels like there is no added value to the lib by enabling it in the Playground module of RNN.

birkir · 2021-05-30T17:58:53Z

It would make sense to use Hermes on android too, right?

Hey @birkir :]

The js side of RNN works with Hermes and JSC, it's up to the host app to use Hermes or other variants, we can enable it by default, but it feels like there is no added value to the lib by enabling it in the Playground module of RNN.

Hey, you probably misunderstood me.

This PR enables hermes on iOS, but not Android and I was only commenting on the inconsistency in the Playground app.

I know the package has nothing to do with Hermes outwards.

swabbass · 2021-06-01T12:58:14Z

It would make sense to use Hermes on android too, right?

Hey @birkir :]
The js side of RNN works with Hermes and JSC, it's up to the host app to use Hermes or other variants, we can enable it by default, but it feels like there is no added value to the lib by enabling it in the Playground module of RNN.

Hey, you probably misunderstood me.

This PR enables hermes on iOS, but not Android and I was only commenting on the inconsistency in the Playground app.

I know the package has nothing to do with Hermes outwards.

Hey sorry, I did not get that from your comment but hey, you have a point here, sure.

drop flavors

# Conflicts: # lib/android/app/src/main/java/com/reactnativenavigation/options/HardwareBackButtonOptions.kt # lib/android/app/src/main/java/com/reactnativenavigation/viewcontrollers/modal/ModalPresenter.java # lib/android/app/src/main/java/com/reactnativenavigation/viewcontrollers/stack/StackController.java # lib/android/app/src/reactNative63/java/com/reactnativenavigation/react/NavigationReactNativeHost.java

svbutko · 2021-10-05T09:57:02Z

What about dropping support for iOS 11 and iOS 12?
And keeping last 3 major versions (13,14,15)?
wdyt?

It will remove good part of the code and separated tests

svbutko · 2021-10-05T09:58:23Z

https://developer.apple.com/support/app-store/

With iOS 15 release these numbers will go even lower

yogevbd · 2021-10-05T11:10:30Z

@svbutko I need to check with our production team if they plan on removing support for iOS 12 in the Wix app. If so we defiantly can

svbutko · 2021-10-07T05:55:59Z

There are several requirements to upgrade AGP properly to 7.0.2:
facebook/react-native#32186

svbutko · 2021-10-07T06:00:48Z

And if it's going to be AGP 7.0.2 then I would mention how to install JDK 11:

brew install --cask adoptopenjdk/openjdk/adoptopenjdk11

Since most of the users have JDK 8 only installed

swabbass · 2021-10-07T06:11:23Z

And if it's going to be AGP 7.0.2 then I would mention how to install JDK 11:

brew install --cask adoptopenjdk/openjdk/adoptopenjdk11

Since most of the users have JDK 8 only installed

yup, we can mention that it is already running e2e locally in a release.
Our CI should have JDK 11 installed also.

swabbass · 2021-10-07T06:37:20Z

Users can choose to have such gradle.properties:

# For adoptopenjdk: brew install --cask adoptopenjdk/openjdk/adoptopenjdk11
#org.gradle.java.home=/Library/Java/JavaVirtualMachines/adoptopenjdk-11.jdk/Contents/Home

# For Android Studio embedded JVM version
org.gradle.java.home=/Applications/Android Studio.app/Contents/jre/Contents/Home

@svbutko wdyt?

svbutko · 2021-10-07T06:40:19Z

Users can choose to have such gradle.properties:

# For adoptopenjdk: brew install --cask adoptopenjdk/openjdk/adoptopenjdk11
#org.gradle.java.home=/Library/Java/JavaVirtualMachines/adoptopenjdk-11.jdk/Contents/Home

# For Android Studio embedded JVM version
org.gradle.java.home=/Applications/Android Studio.app/Contents/jre/Contents/Home

@svbutko wdyt?

LGTM, but I think it's worth mentioning Windows users too:

choco install -y nodejs.install openjdk11

I myself on macOS but I know many people use Windows for development

swabbass · 2021-10-07T06:42:12Z

Users can choose to have such gradle.properties:
# For adoptopenjdk: brew install --cask adoptopenjdk/openjdk/adoptopenjdk11
#org.gradle.java.home=/Library/Java/JavaVirtualMachines/adoptopenjdk-11.jdk/Contents/Home

# For Android Studio embedded JVM version
org.gradle.java.home=/Applications/Android Studio.app/Contents/jre/Contents/Home
@svbutko wdyt?
LGTM, but I think it's worth mentioning Windows users too:

choco install -y nodejs.install openjdk11

I myself on macOS but I know many people use Windows for development

Showing love for Windows devs.

svbutko · 2021-10-07T06:44:57Z

Users can choose to have such gradle.properties:
# For adoptopenjdk: brew install --cask adoptopenjdk/openjdk/adoptopenjdk11
#org.gradle.java.home=/Library/Java/JavaVirtualMachines/adoptopenjdk-11.jdk/Contents/Home

# For Android Studio embedded JVM version
org.gradle.java.home=/Applications/Android Studio.app/Contents/jre/Contents/Home
@svbutko wdyt?
LGTM, but I think it's worth mentioning Windows users too:
choco install -y nodejs.install openjdk11
I myself on macOS but I know many people use Windows for development
Showing love for Windows devs.

I started working with RN around 5 years ago on Windows (transitioned to macOS in 2019) and I went through all of the possible issues so I know what it's like 😄

swabbass · 2021-10-07T07:21:27Z

Update:

We got a couple of issues running unit tests (JS), babel related as it looks:
Also, E2E we got jasmine stuff that seems to be broken:
Android Build debug/release are passing.

retyui · 2021-10-09T08:10:08Z

How about to use microsoft/react-native-test-app to easily support playground app?

swabbass · 2021-10-11T13:35:12Z

Closed in favour of #7305, this will be used as a reference for changes on native.

Upgrade playground react-native version to 0.64

e0517c8

yogevbd added the Infrastructure label Mar 15, 2021

yogevbd added this to the 8.0.0 milestone Mar 15, 2021

Sergey Ilyevsky and others added 2 commits April 7, 2021 13:08

dummy commit to solve some jenkins problem

423c792

dummy

d3204eb

stale bot added the 🏚 stale label May 27, 2021

yogevbd removed the 🏚 stale label May 27, 2021

swabbass assigned swabbass and yogevbd May 30, 2021

swabbass mentioned this pull request May 31, 2021

downgrade kotlin #7141

Merged

swabbass added 13 commits June 1, 2021 16:02

Merge branch 'master' into RN64

3bb8d64

move flavored code to main src

ae2e8b3

drop flavors

drop flavors in gradle

56605dd

enable hermes by default

8a30693

remove jsc

ef1c97f

kotlin 1.4

e30f70f

reimport color parser

167b72b

refactor removed REACT_NATVE_VERSION_MINOR

a329e4a

use Hermes as default

2e667b2

Allow draw over on android

6a2c9e7

Merge branch 'master' into RN64

9763b9f

remove flavor in testing

f6dc994

fix unit test

313e8d4

svbutko added 2 commits October 4, 2021 13:04

Merge branch 'master' into RN64

2d49961

Merge branch 'master' into RN64

8e33cad

swabbass mentioned this pull request Oct 5, 2021

Fix Android project warnings #7288

Merged

svbutko added 2 commits October 5, 2021 12:31

svbutko and others added 8 commits October 5, 2021 19:07

Merge branch 'master' into RN64

18c6fbf

Merge branch 'master' into RN64

bd6c1b6

Merge branch 'master' into RN64

34a3b0a

AGP 7

eca97bb

remove kotlin exts

5b7279b

fix deprecations

143be6e

update reanimated for rn66

35fe097

upgrade reanimated

59496d3

fix release android builds

35fad79

Merge branch 'master' into RN64

10cb2d1

swabbass closed this Oct 11, 2021

swabbass removed a link to an issue Oct 12, 2021

Hiding the bottom navigation bar on Android creates a gap at the bottom of the view #7199

Closed

Conversation

yogevbd commented Mar 15, 2021 • edited by swabbass Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Release Notes

ReactNative

Android

iOS

Uh oh!

swabbass commented Apr 11, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stale bot commented May 27, 2021

Uh oh!

yogevbd commented May 27, 2021

Uh oh!

birkir commented May 29, 2021

Uh oh!

swabbass commented May 30, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

birkir commented May 30, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

swabbass commented Jun 1, 2021

Uh oh!

svbutko commented Oct 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

svbutko commented Oct 5, 2021

Uh oh!

yogevbd commented Oct 5, 2021

Uh oh!

svbutko commented Oct 7, 2021

Uh oh!

svbutko commented Oct 7, 2021

Uh oh!

swabbass commented Oct 7, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

swabbass commented Oct 7, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

svbutko commented Oct 7, 2021

Uh oh!

swabbass commented Oct 7, 2021

Uh oh!

svbutko commented Oct 7, 2021

Uh oh!

swabbass commented Oct 7, 2021

Update:

Uh oh!

retyui commented Oct 9, 2021

Uh oh!

swabbass commented Oct 11, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

yogevbd commented Mar 15, 2021 •

edited by swabbass

Loading

swabbass commented Apr 11, 2021 •

edited

Loading

swabbass commented May 30, 2021 •

edited

Loading

birkir commented May 30, 2021 •

edited

Loading

svbutko commented Oct 5, 2021 •

edited

Loading

swabbass commented Oct 7, 2021 •

edited

Loading

swabbass commented Oct 7, 2021 •

edited

Loading