Skip to content

CI: bump react-native-android docker image to 5.0, includes JDK 11#32186

Closed
dulmandakh wants to merge 2 commits intofacebook:mainfrom
dulmandakh:jdk-11
Closed

CI: bump react-native-android docker image to 5.0, includes JDK 11#32186
dulmandakh wants to merge 2 commits intofacebook:mainfrom
dulmandakh:jdk-11

Conversation

@dulmandakh
Copy link
Contributor

@dulmandakh dulmandakh commented Sep 11, 2021

Summary

Bump react-native-android docker image to 5.0, which includes JDK 11.

Changelog

[Internal] [Changed] - bump react-native-android docker image to 5.0, which includes JDK 11.

Test Plan

Android CI must be green

@dulmandakh dulmandakh requested a review from hramos as a code owner September 11, 2021 13:30
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. labels Sep 11, 2021
@pull-bot
Copy link

pull-bot commented Sep 11, 2021

Warnings
⚠️ 🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against c8cf4d1

@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Sep 11, 2021
@analysis-bot
Copy link

analysis-bot commented Sep 11, 2021

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 5518b6d
Branch: main

@facebook-github-bot
Copy link
Contributor

@cortinico has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@cortinico
Copy link
Contributor

Seems like the CI is failing as we specify UseCGroupMemoryLimitForHeap and we should instead specify UseContainerSupport:

- _JAVA_OPTIONS: "-XX:+UnlockExperimentalVMOptions -XX:+UseCGroupMemoryLimitForHeap"

More on this here: https://support.circleci.com/hc/en-us/articles/360048152911

Don't you mind giving it a try?

@facebook-github-bot
Copy link
Contributor

@cortinico has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@cortinico has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@analysis-bot
Copy link

analysis-bot commented Sep 15, 2021

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,477,943 -26
android hermes armeabi-v7a 7,775,189 -25
android hermes x86 8,947,093 -26
android hermes x86_64 8,894,003 -28
android jsc arm64-v8a 9,791,890 +12
android jsc armeabi-v7a 8,752,625 +23
android jsc x86 9,740,716 +17
android jsc x86_64 10,341,569 +14

Base commit: a44962f
Branch: main

@dulmandakh
Copy link
Contributor Author

@cortinico this PR is not ready yet

@cortinico cortinico marked this pull request as draft September 15, 2021 13:04
@cortinico
Copy link
Contributor

@cortinico this PR is not ready yet

Thanks for pointing out. I've converted it to a draft PR. Feel free to ping me once you're ready to land this 👍

@svbutko
Copy link
Contributor

svbutko commented Oct 4, 2021

When it's going to be ready can it be possible to also bump AGP then to 7.0.2 with this PR?

@dulmandakh dulmandakh marked this pull request as ready for review November 12, 2021 16:18
@dulmandakh dulmandakh changed the title use JDK 11 in Gradle CI: bump react-native-android docker image to 5.0 Nov 12, 2021
@dulmandakh
Copy link
Contributor Author

@cortinico could you please look into CI failure with JDK 11. It's strange.

@dulmandakh
Copy link
Contributor Author

solved the CI issue 👍

@dulmandakh dulmandakh changed the title CI: bump react-native-android docker image to 5.0 CI: bump react-native-android docker image to 5.0, includes JDK 11 Nov 12, 2021
@facebook-github-bot
Copy link
Contributor

@cortinico has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Nov 12, 2021
@facebook-github-bot
Copy link
Contributor

@cortinico merged this pull request in 9e72235.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants