Skip to content

Bump Kotlin and Gradle versions#32319

Closed
svbutko wants to merge 3 commits intofacebook:mainfrom
svbutko:patch-1
Closed

Bump Kotlin and Gradle versions#32319
svbutko wants to merge 3 commits intofacebook:mainfrom
svbutko:patch-1

Conversation

@svbutko
Copy link
Contributor

@svbutko svbutko commented Oct 2, 2021

Summary

Bump Kotlin version to 1.5.31 to include following changes:

https://kotlinlang.org/docs/whatsnew15.html
https://kotlinlang.org/docs/whatsnew1520.html
https://kotlinlang.org/docs/whatsnew1530.html

Primarily:

  • Native support for Apple silicon
  • Kotlin/JS IR backend reaches Beta
  • Improved Gradle plugin experience
  • Performance improvements

Changelog

[Android] [Changed] - Bump Kotlin version to 1.5.31
[Android] [Changed] - Bump Gradle version to 7.2

@facebook-github-bot
Copy link
Contributor

Hi @svbutko!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@react-native-bot react-native-bot added the Platform: Android Android applications. label Oct 2, 2021
@pull-bot
Copy link

pull-bot commented Oct 2, 2021

Messages
📖 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against da3d4e4

@analysis-bot
Copy link

analysis-bot commented Oct 2, 2021

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 36f3bf2

@analysis-bot
Copy link

analysis-bot commented Oct 2, 2021

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,715,896 -132
android hermes armeabi-v7a 7,244,133 -122
android hermes x86 8,135,280 -65
android hermes x86_64 8,100,865 -35
android jsc arm64-v8a 9,635,179 -131
android jsc armeabi-v7a 8,550,937 -125
android jsc x86 9,648,851 -68
android jsc x86_64 10,258,121 -28

Base commit: 36f3bf2

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 2, 2021
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Oct 2, 2021
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@facebook-github-bot
Copy link
Contributor

@cortinico has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@cortinico
Copy link
Contributor

I believe we can merge this, yet I'd like to keep the Kotlin version and the Gradle's embedded Kotlin version aligned as much as possible. If we could bump Kotlin to 1.5 AND bump Gradle to 7.2 in the same PR would be preferred 👍 If not we can also do it in two subsequent PRs.

@svbutko
Copy link
Contributor Author

svbutko commented Oct 3, 2021

I believe we can merge this, yet I'd like to keep the Kotlin version and the Gradle's embedded Kotlin version aligned as much as possible. If we could bump Kotlin to 1.5 AND bump Gradle to 7.2 in the same PR would be preferred 👍 If not we can also do it in two subsequent PRs.

I wanted to do it in the next PR after this one gets merged but if you're ok with it then it would be perfect.

@svbutko svbutko changed the title Bump Kotlin to 1.5.31 Bump Kotlin and Gradle versions Oct 3, 2021
@svbutko
Copy link
Contributor Author

svbutko commented Oct 3, 2021

I believe we can merge this, yet I'd like to keep the Kotlin version and the Gradle's embedded Kotlin version aligned as much as possible. If we could bump Kotlin to 1.5 AND bump Gradle to 7.2 in the same PR would be preferred 👍 If not we can also do it in two subsequent PRs.

Done

@svbutko
Copy link
Contributor Author

svbutko commented Oct 3, 2021

Should there also be some compatibility notes regarding Java 11, because Gradle 7 runs on Java 11?

Like change this line of Java Development Kit installation from website:

brew install --cask adoptopenjdk/openjdk/adoptopenjdk8

To

brew install --cask adoptopenjdk/openjdk/adoptopenjdk11

@svbutko
Copy link
Contributor Author

svbutko commented Oct 3, 2021

Added draft to website but it has to be mentioned within code too I think

@facebook-github-bot
Copy link
Contributor

@cortinico has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@cortinico
Copy link
Contributor

Please revert the bump to AGP 7.x
That imposes the usage of JDK 11 and it would requires a bump on the docker image (see also #32186).
We should be fine with just Gradle 7.2 and Kotlin 1.5

@svbutko
Copy link
Contributor Author

svbutko commented Oct 4, 2021

Please revert the bump to AGP 7.x
That imposes the usage of JDK 11 and it would requires a bump on the docker image (see also #32186).
We should be fine with just Gradle 7.2 and Kotlin 1.5

Done @cortinico

@facebook-github-bot
Copy link
Contributor

@cortinico has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@cortinico
Copy link
Contributor

Done @cortinico

Great thanks for doing that 👍 We should be good merging this at this stage. Just as a FYI, I believe our internal CI will fail due to missing dependencies in the offline mirror we have. I'm currently taking some days off, will see if I can find a colleague that can land this otherwise I can take care of it beginning of next week.

@svbutko
Copy link
Contributor Author

svbutko commented Oct 6, 2021

Done @cortinico

Great thanks for doing that 👍 We should be good merging this at this stage. Just as a FYI, I believe our internal CI will fail due to missing dependencies in the offline mirror we have. I'm currently taking some days off, will see if I can find a colleague that can land this otherwise I can take care of it beginning of next week.

Surprisingly it didn't fail from what I can see 😄

@facebook-github-bot
Copy link
Contributor

@cortinico has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@cortinico
Copy link
Contributor

Surprisingly it didn't fail from what I can see 😄

It actually does. I'm unsure why Github status is not up to date, but it fails internally for the reason I mentioned. I'll take care of this shortly 👍

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @svbutko in 9ae3367.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Platform: Android Android applications. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants