Conversation
|
Hi @svbutko! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Base commit: 36f3bf2 |
Base commit: 36f3bf2 |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
@cortinico has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
I believe we can merge this, yet I'd like to keep the Kotlin version and the Gradle's embedded Kotlin version aligned as much as possible. If we could bump Kotlin to 1.5 AND bump Gradle to 7.2 in the same PR would be preferred 👍 If not we can also do it in two subsequent PRs. |
I wanted to do it in the next PR after this one gets merged but if you're ok with it then it would be perfect. |
Done |
|
Should there also be some compatibility notes regarding Java 11, because Gradle 7 runs on Java 11? Like change this line of Java Development Kit installation from website:
To
|
|
Added draft to website but it has to be mentioned within code too I think |
|
@cortinico has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
Please revert the bump to AGP 7.x |
Done @cortinico |
|
@cortinico has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Great thanks for doing that 👍 We should be good merging this at this stage. Just as a FYI, I believe our internal CI will fail due to missing dependencies in the offline mirror we have. I'm currently taking some days off, will see if I can find a colleague that can land this otherwise I can take care of it beginning of next week. |
Surprisingly it didn't fail from what I can see 😄 |
|
@cortinico has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
It actually does. I'm unsure why Github status is not up to date, but it fails internally for the reason I mentioned. I'll take care of this shortly 👍 |
|
This pull request was successfully merged by @svbutko in 9ae3367. When will my fix make it into a release? | Upcoming Releases |
Summary
Bump Kotlin version to 1.5.31 to include following changes:
https://kotlinlang.org/docs/whatsnew15.html
https://kotlinlang.org/docs/whatsnew1520.html
https://kotlinlang.org/docs/whatsnew1530.html
Primarily:
Changelog
[Android] [Changed] - Bump Kotlin version to 1.5.31
[Android] [Changed] - Bump Gradle version to 7.2