ENH: Orient to normal #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
Author
|
This is what i get in the updated example, suggesting that the signs are now properly flipped:
For reference this is our current output: http://mne-tools.github.io/dev/auto_examples/inverse/plot_lcmv_beamformer.html |
Author
|
@britta-wstnr you might be interested in this output |
wmvanvliet
force-pushed
the
cleanup_beamformer
branch
2 times, most recently
from
833e64b to
efa3c40
Compare
Owner
|
Tnx @larsoner ! |
wmvanvliet
pushed a commit
that referenced
this pull request
Dec 2, 2021
* make contrib guide more friendly * move icons to beginning Co-authored-by: Richard Höchenberger <richard.hoechenberger@gmail.com> * more consistent icon style * Additions to contrib guide PR (#6) * make line about fork clearer * minimize white space and improve wording * improve some wording Co-authored-by: Richard Höchenberger <richard.hoechenberger@gmail.com> Co-authored-by: Britta Westner <britta.wstnr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chooses the sign of the max ori to match whatever the source normal is defined as in the forward (and thus in original src).