Conversation
Fix Rubocop Issue
More Xcode stuff
jkmassel
force-pushed
the
add/buildkite
branch
6 times, most recently
from
40c61c6 to
c4b4451
Compare
Test Add runtime validation Make Rubocop Happy
jkmassel
force-pushed
the
add/buildkite
branch
from
1f25fe9 to
9a63754
Compare
| BlueprintName = "AztecTests" | ||
| ReferencedContainer = "container:Aztec.xcodeproj"> | ||
| </BuildableReference> | ||
| <SkippedTests> |
There was a problem hiding this comment.
These tests don't work under iOS 15, so they're disabled for now
There was a problem hiding this comment.
I was going to open a PR similar to wordpress-mobile/MediaEditor-iOS#29 here, but I'll wait for input on my question regarding the future of this library.
| end | ||
| end | ||
|
|
||
| def create_simulator(runtime, device) |
There was a problem hiding this comment.
I was surprised that this wasn't already a fastlane action – might be worth moving this into the release toolkit in the future (in order to be able to guarantee that we run tests on the desired runtime).
mokagio
left a comment
mokagio
left a comment
There was a problem hiding this comment.
We can either fix the tests, or wait for a future CI image that has an iOS 14 runtime. Might be worth discussing?
My vote is for fixing the tests.
I'm also not sure what the state of Aztec is, but I think it's getting closer and closer to be removable? Or do we plan to leave it around for those who want to switch back to the "classic editor" in the app?
If it's days are numbered, we might as well carry on like this and direct effort to decommissioning it.
| ################# | ||
| # Build and Test | ||
| ################# | ||
| - label: "🧪 Build and Test" |
There was a problem hiding this comment.
Muscle memory was going to make me suggest to use 🔬 but I don't know whether that's appropriate for a "Build and Test" step 🤔 😅
| attributes = { | ||
| LastSwiftUpdateCheck = 0800; | ||
| LastUpgradeCheck = 1230; | ||
| LastUpgradeCheck = 1310; |
| buildlog_path: File.join(__dir__, '.build', 'logs'), | ||
| derived_data_path: File.join(__dir__, '.build', 'derived-data'), | ||
| ensure_devices_found: true | ||
| ) |
There was a problem hiding this comment.
Have you considered splitting these in two lanes and running them in parallel in CI?
I'm guessing because the tests themselves don't take that long to run (the lane runs less than a minute with no DerivedData on my 2019 Intel) doing this might actually result in more total CI setup time for the parallel agents, which would be wasteful. 👍
There was a problem hiding this comment.
Considered, but the overhead is a lot – I'd be open to splitting them if this repo starts doing a lot of builds though? 🤷♂️
3 participants
Adds Buildkite support.
In order to make that work, this PR also:
AnyObjectdeclarations.We can either fix the tests, or wait for a future CI image that has an iOS 14 runtime. Might be worth discussing?