Use XCTExpectFailure instead of skipping tests in scheme#29
Merged
Conversation
Merged
Contributor
Author
|
@leandroalonso: GitHub suggested you as a reviewer (I guess because you touched the test file recently), plus @jkmassel cc-ed you in #28. It would be great if you had the time to look at the actually fix it, making this PR redundant 😄 (In that case, please cc me because now I'm curious) |
mokagio
commented
Feb 4, 2022
| hub.loadingImage(at: 1) | ||
| hub.loadingImage(at: 0) | ||
|
|
||
| XCTExpectFailure("We noticed this test failing in https://github.com/wordpress-mobile/MediaEditor-iOS/pull/28 but did not have the bandwidth to fix it") |
Contributor
Author
There was a problem hiding this comment.
I could have extracted this duplicated message in a let, but I didn't want to over-engineer what should be a temporary approach.
leandroalonso
approved these changes
Feb 4, 2022
My concern with using the scheme (or a Test Plan) to skip tests is that the setting is tucked away behind multiple UI layers and mouse clicks. I worry that we'll forget about it. By still running these two tests and marking their failures as expected, we make the issue more visible.
mokagio
force-pushed
the
add/buildkite-skip-tests-inline
branch
from
0fe8320 to
094869a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My concern with using the scheme (or a Test Plan) to skip tests is that the setting is tucked away behind multiple UI layers and mouse clicks. I worry that we'll forget about it.
By still running these two tests and marking their failures as expected, we make the issue more visible.
PR submission checklist:
RELEASE-NOTES.txtif necessary. – N.A.