Conversation
jkmassel
force-pushed
the
add/buildkite
branch
from
ff97899 to
1ee8ffe
Compare
jkmassel
force-pushed
the
add/buildkite
branch
from
b1324b2 to
bbc3230
Compare
mokagio
left a comment
mokagio
left a comment
There was a problem hiding this comment.
I checked out this branch locally and verified the SPM setup works (which to be fair was sort of unnecessary, given that CI built fine)
Happy to see you already marked the CI tasks as required 👍
My suggestion in #29 is not required for this to be merged into trunk.
| aws-eventstream (~> 1, >= 1.0.2) | ||
| babosa (1.0.4) | ||
| claide (1.0.3) | ||
| cocoapods (1.8.4) |
There was a problem hiding this comment.
The latest CocoaPods version at the time of this comment is 1.11.2. Should we take the chance of this PR to upgrade?
The same likely goes for Fastlane, too.
| s.description = <<-DESC | ||
| An extensible Media Editor for iOS that allows editing single or multiple images. | ||
| DESC | ||
| DESC |
There was a problem hiding this comment.
CocoaPods likely does some post processing on this, but the heredoc with the - will keep all the spaces used for indentation here:
We could either remove the spaces or use the <<~ heredoc, which strips the left spaces.
In the latter, Rubocop tells me to use two spaces for indentation, so:
Pod::Spec.new do |s|
# ...
s.description = <<~DESC
An extensible Media Editor for iOS that allows editing single or multiple images.
DESC| project: 'MediaEditor.xcodeproj', | ||
| scheme: 'MediaEditor', | ||
| devices: ['iPhone 11'], | ||
| deployment_target_version: '14.5', |
There was a problem hiding this comment.
Have you tried the latest for Xcode 13.0 (used in CI), which I guess would be 15?
There was a problem hiding this comment.
FWIW, I tried this on my machine and it worked
| deployment_target_version: '14.5', | |
| deployment_target_version: '15.0', |
There was a problem hiding this comment.
So...as identified in https://github.com/wordpress-mobile/AztecEditor-iOS/pull/1349/files#diff-dff4b99d4e651ab9d7597876ec8dbe92aa934e42c0fb55f4aadd6c106fc96688R37, this value really doesn't do much (it'll use iOS 15 under the hood no matter what this is set to).
I figure we can run around and update all our projects once:
- That PR lands
- I'm able to extract the simulator creation bits into the release toolkit, then update all our projects to validate the available simulator versions.
| <SkippedTests> | ||
| <Test | ||
| Identifier = "MediaEditorHubTests/testDoNotShowActivityIndicatorIfImageIsNotBeingLoaded()"> | ||
| </Test> | ||
| <Test | ||
| Identifier = "MediaEditorHubTests/testShowActivityIndicatorWhenSwipingToAnImageBeingLoaded()"> | ||
| </Test> | ||
| </SkippedTests> |
There was a problem hiding this comment.
Whilst skipping these is a temporary tech debt incurrence, I'd like to suggest we use XCTExpectFailure instead.
I opened #29 for this and added a rationale.
TIL that the noun deriving from the verb incur is incurrence, not incursion. However, "tech debt incursion" might still be appropriate ⚔️ ⚔️ ⚔️
There was a problem hiding this comment.
tech debt incursion
😱 😂
Co-authored-by: Gio Lodi <giovanni.lodi42@gmail.com>
|
Merging this to unblock #29, and I'll post a followup soon to address the simulator stuff Gio mentioned. |
2 participants
Adds Buildkite to the project, and removes CircleCI. Also: