Skip to content

Use XCTExpectFailure instead of skipping tests in scheme #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mokagio merged 1 commit into from
Feb 7, 2022
Merged

Use XCTExpectFailure instead of skipping tests in scheme #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions MediaEditor.xcodeproj/xcshareddata/xcschemes/MediaEditor.xcscheme
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,14 +37,6 @@
BlueprintName = "Tests"
ReferencedContainer = "container:MediaEditor.xcodeproj">
</BuildableReference>
<SkippedTests>
<Test
Identifier = "MediaEditorHubTests/testDoNotShowActivityIndicatorIfImageIsNotBeingLoaded()">
</Test>
<Test
Identifier = "MediaEditorHubTests/testShowActivityIndicatorWhenSwipingToAnImageBeingLoaded()">
</Test>
</SkippedTests>
</TestableReference>
</Testables>
</TestAction>
Expand Down
2 changes: 2 additions & 0 deletions Tests/MediaEditorHubTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,7 @@ class MediaEditorHubTests: XCTestCase {
hub.imagesCollectionView.reloadData()
hub.loadingImage(at: 0)

XCTExpectFailure("We noticed this test failing in https://github.com/wordpress-mobile/MediaEditor-iOS/pull/28 but did not have the bandwidth to fix it")
hub.collectionView(hub.thumbsCollectionView, didSelectItemAt: IndexPath(row: 1, section: 0))

expect(hub.activityIndicatorView.isHidden).to(beTrue())
Expand All @@ -118,6 +119,7 @@ class MediaEditorHubTests: XCTestCase {
hub.loadingImage(at: 1)
hub.loadingImage(at: 0)

XCTExpectFailure("We noticed this test failing in https://github.com/wordpress-mobile/MediaEditor-iOS/pull/28 but did not have the bandwidth to fix it")
Copy link
Contributor Author

@mokagio mokagio Feb 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could have extracted this duplicated message in a let, but I didn't want to over-engineer what should be a temporary approach.

hub.collectionView(hub.thumbsCollectionView, didSelectItemAt: IndexPath(row: 1, section: 0))

expect(hub.activityIndicatorView.isHidden).to(beFalse())
Expand Down