Skip to content

Fix some view lifecycle inconsistencies #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mokagio merged 3 commits into from
Jun 20, 2023
Merged

Fix some view lifecycle inconsistencies #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c42177d
Call appropriate `super` method from `viewWillDisappear`
mokagio Jun 20, 2023
a0dfd6f
Add a missing call to `super.viewDidLoad`
mokagio Jun 20, 2023
4ccf425
Add changelog entry for #40
mokagio Jun 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ _None._

### Bug Fixes

_None._
- Fix a `viewWillDisappear` method calling `super.viewWillAppear` [#40]

### Internal Changes

Expand Down
1 change: 1 addition & 0 deletions Sources/Capabilities/Filters/MediaEditorFilters.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ class MediaEditorFilters: UIViewController {
private var selectedFilterIndex = IndexPath(row: 0, section: 0)

override func viewDidLoad() {
super.viewDidLoad()
imageView.image = image
filtersCollectionView.dataSource = self
filtersCollectionView.delegate = self
Expand Down
2 changes: 1 addition & 1 deletion Sources/MediaEditor.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ open class MediaEditor: UINavigationController {
}

public override func viewWillDisappear(_ animated: Bool) {
super.viewWillAppear(animated)
super.viewWillDisappear(animated)
currentCapability = nil
}

Expand Down