Merged
Conversation
There are reasons to believe the method in `UIViewController` to be doing nothing: https://stackoverflow.com/a/51995637/809944 However, given we don't know for sure and that the behavior might change at any time, it seems wise to call it.
staskus
approved these changes
Jun 20, 2023
staskus
left a comment
staskus
left a comment
There was a problem hiding this comment.
Thanks for the fix! This is an easy way to get into weird crashes and unexpected behavior.
This was referenced Jun 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I run into this while looking into wordpress-mobile/WordPress-iOS#20849
PR submission checklist:
CHANGELOG.mdif necessary.