Skip to content

Use MediaEditor 1.2.2#20910

Merged
mokagio merged 1 commit intotrunkfrom
mokagio/use-latest-media-editor
Jun 20, 2023
Merged

Use MediaEditor 1.2.2#20910
mokagio merged 1 commit intotrunkfrom
mokagio/use-latest-media-editor

Conversation

@mokagio
Copy link
Contributor

@mokagio mokagio commented Jun 20, 2023

This version has a fix for a possible life-cycle issue, see wordpress-mobile/MediaEditor-iOS#40

Unfortunately, I've never run into a crash due to the offending code. I only noticed the inconsistency and addressed it.

This version has a fix for a possible life-cycle issue.
@mokagio mokagio added this to the 22.6 ❄️ milestone Jun 20, 2023
@mokagio mokagio requested review from guarani and staskus June 20, 2023 10:46
@mokagio mokagio enabled auto-merge June 20, 2023 10:47
@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr20910-3321032
Version22.6
Bundle IDcom.jetpack.alpha
Commit3321032
App Center Buildjetpack-installable-builds #5072
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr20910-3321032
Version22.6
Bundle IDorg.wordpress.alpha
Commit3321032
App Center BuildWPiOS - One-Offs #6046
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Copy link
Contributor

@guarani guarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix in wordpress-mobile/MediaEditor-iOS#40 looks safe, and @staskus has approved it. Approving here so this can be merged.

@mokagio mokagio merged commit 3df0c26 into trunk Jun 20, 2023
@mokagio mokagio deleted the mokagio/use-latest-media-editor branch June 20, 2023 20:00
@guarani guarani modified the milestones: 22.6 ❄️, 22.5.1 Jun 21, 2023
@guarani
Copy link
Contributor

guarani commented Jun 21, 2023

👋 @mokagio, was included in the hotfix release right? I think so because it's mentioned in #20929 and it's in that PRs diff, so I updated the milestone, but just want to confirm 🙇

@mokagio
Copy link
Contributor Author

mokagio commented Jun 21, 2023

Confirmed. Thank you for updating the milestone 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants