Skip to content

Disables the interactivePopGestureRecognizer to avoid conflicts#8

Merged
leandroalonso merged 1 commit intodevelopfrom
issue/6_fix_left_crop_handles
Jan 28, 2020
Merged

Disables the interactivePopGestureRecognizer to avoid conflicts#8
leandroalonso merged 1 commit intodevelopfrom
issue/6_fix_left_crop_handles

Conversation

@leandroalonso
Copy link
Contributor

Fixes #7

To test

Using an iOS 12 simulator and/or device:

  1. Tap Crop
  2. Grab the left handle in the crop screen
  3. Check that it works properly

Also, try to swipe left-from-right. The view controller should not start to pop out.

An example of conflict: the user wasn't able to select the crop handles
@leandroalonso leandroalonso added the bug Something isn't working label Jan 28, 2020
Copy link
Contributor

@emilylaguna emilylaguna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Confirmed this is fixed on iOS 12 and below.

I tested on iOS Simulator 13.3, 12.4, and 11.4

@leandroalonso leandroalonso merged commit ee18602 into develop Jan 28, 2020
@leandroalonso leandroalonso deleted the issue/6_fix_left_crop_handles branch January 28, 2020 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to grab the left crop handles on iOS 12 and below

2 participants