Conversation
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
|
You can test the changes on this Pull Request by downloading the APKs: |
| assertTrue("'Post published' toast was not displayed", | ||
| waitForElementToBeDisplayedWithoutFailure(onView(withText(R.string.post_published)))); |
There was a problem hiding this comment.
🤔 Having the assertion failure message as the first argument makes the code a bit confusing. assertTrue(boolean condition, String message) would make it better to read. ¯\_(ツ)_/¯
There was a problem hiding this comment.
Completely agree with that, I needed a second look to see that that was supposed to be the error message.
jostnes
left a comment
There was a problem hiding this comment.
Added a curious question and a comment on the verification point for one of the test cases.
I don't understand the framework enough to give constructive comments, but the tests looks good to me!
WordPress/src/androidTest/java/org/wordpress/android/e2e/BlockEditorTests.java
Show resolved
Hide resolved
WordPress/src/androidTest/java/org/wordpress/android/e2e/pages/BlockEditorPage.java
Show resolved
Hide resolved
| assertTrue("'Post published' toast was not displayed", | ||
| waitForElementToBeDisplayedWithoutFailure(onView(withText(R.string.post_published)))); |
There was a problem hiding this comment.
Completely agree with that, I needed a second look to see that that was supposed to be the error message.
jostnes
left a comment
There was a problem hiding this comment.
The tests look good to me! Tested this locally and tests are working as expected. CI runs are green as well.
Description
After the classic editor was made unavailable for new posts a couple of tests covering post creation were disabled.
Since the ability to create a post is considered critical to be automated, this PR adds a few tests to the new block editor covering the disabled scenarios and a new scenario covering the
HTML mode.publishSimplePost: checks that a simple post with only title and text can be published.publishFullPost: checks that a post with title, text, image, category and tag can be published.blockEditorCanDisplayElementAddedInHtmlMode: checks that an element aded in HTML Mode can be displayed in Visual mode.Testing Instructions
publishSimplePost,publishFullPostand blockEditorCanDisplayElementAddedInHtmlMode tests included.Regression Notes
Potential unintended areas of impact
Changes would only affect ui tests.
What I did to test those areas of impact (or what existing automated tests I relied on)
Checked that all tests are passing locally an on CI.
What automated tests I added (or what prevented me from doing so)
publishSimplePostpublishFullPostblockEditorCanDisplayElementAddedInHtmlModePR submission checklist:
RELEASE-NOTES.txtif necessary.