remove duplicated WPSupportUtils method#15789
Merged
Conversation
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
AliSoftware
approved these changes
Jan 4, 2022
Contributor
AliSoftware
left a comment
AliSoftware
left a comment
There was a problem hiding this comment.
Removed lines are indeed exactly the same as the ones from a couple of lines just above so seems coherent to remove the duplicate declaration (which likely arose from a git conflict auto-resolution gone wrong) 👍
Generated by 🚫 dangerJS |
|
You can test the changes on this Pull Request by downloading the APKs: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes a WPSupportUtils method that got duplicated in recently merged PRs (this and this) and it's making the build to fail.
The methods are exactly the same, so I just removed one of them.
To test:
Tests must pass on CI.
Regression Notes
Potential unintended areas of impact
This PR could only impact the tests.
What I did to test those areas of impact (or what existing automated tests I relied on)
N/A
What automated tests I added (or what prevented me from doing so)
N/A
PR submission checklist:
RELEASE-NOTES.txtif necessary.