Integrated locale handling changes in WordPressKit

[ghost]

Description

Fixes #78, which exposes the ability to inject different locale keys into WordPressComRestApi.

The code can be reviewed as-is; I have only affixed the DO NOT MERGE label to reflect the fact that it is dependent on the review, approval, merge, & versioning of this PR in WordPressKit.

Note: A separate issue has been created in WordPressKit to transition the existing service methods to leverage this implicit locale-handling behavior.

To test:

• Checkout the branch, confirm that it builds & that existing tests pass.
• Review the changes here, which are limited to implicit locale handling of current v2 endpoint calls, as well as the separate of v1 & v2 service methods in ActivityServiceRemote.
• Smoke-test network behavior to confirm no regressions, with an emphasis on modified services (e.g. Rewind, Enhanced Site Creation).

Update release notes:

• If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

[SergioEstevao]

How about creating a method on the Account object called wordPressComRestV2APi and that will return the API object set to the correct v2 locale?

[frosty]

I like this suggestion – it would remove a bit of duplication 👍

[ghost]

Thanks for this suggestion! I considered it during the initial implementation; it didn't seem to help as much as I had hoped.

Because AccountService.defaultWordPressComAccount() is optional, you still have some duplication in the event that returns nil. For example:

let api: WordPressComRestApi
if let account = accountService.defaultWordPressComAccount() {
    api = account.wordPressComRestV2Api
} else {
    api = WordPressComRestApi.anonymousApi(userAgent: WPUserAgent.wordPress(), localeKey: WordPressComRestApi.LocaleKeyV2)
}

In any case, I'll proceed to make this change.

[frosty]

✅ Reviewed the changes
✅ Built and ran tests
✅ Smoke-tested site creation and a few other areas

Looking good, I'd just echo Sergio's suggestion for a possible improvement.

[ghost]

Thanks for the feedback, @SergioEstevao! I have pushed a commit that incorporates your feedback. Would you be willing to take another look?

[SergioEstevao]

Looking good! Thanks for all your patience!