This repository was archived by the owner on Sep 15, 2025. It is now read-only.
Merged
Conversation
ghost
self-assigned this
ghost
requested review from
ghost
changed the title
ghost
mentioned this pull request
1 task
frosty
approved these changes
Feb 6, 2019
Contributor
frosty
left a comment
frosty
left a comment
There was a problem hiding this comment.
Looks good to me! Just a couple of small comments about documentation 👍
Author
|
I have pushed an additional commit that includes the documentation @frosty requested. |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #78. As discussed in the issue, and in the preceding draft PR, we need to be able to inject
_localefor v2 endpoints. This PR allows that (or any value) to be injected via the initializer forWordPressComRestApi.Testing Details
Checkout the branch, confirm that it builds, and that both new & existing tests pass.
Review the code and documentation for additional context.
From
WPiOS, checkout theissue/wpkit-78-locale-integrationbranch and confirm that it compiles & tests pass. Also launch the app and exercise requests to confirm that there are no regressions.Please check here if your pull request includes additional test coverage.