Switched to NSDateComponents to create the date "short string"#1428
Merged
astralbodies merged 2 commits intodevelopfrom Mar 20, 2014
Merged
Switched to NSDateComponents to create the date "short string"#1428astralbodies merged 2 commits intodevelopfrom
astralbodies merged 2 commits intodevelopfrom
Conversation
This change also allows for localization of the units of time single characters. NSDateComponents seems to perform well enough during scrolling - CALayer stuff swamped the CPU comparatively during instrumentation.
Contributor
|
One question for internationalization, do all units always come after the number, i.e. this line here - https://github.com/wordpress-mobile/WordPress-iOS/pull/1428/files#diff-e87b0114f8756216b42fb7660042bceeR22 Besides that, |
Contributor
Author
|
Good point @sendhil - I'm going to dig through WP.com and see where those strings are created for the Reader. |
Contributor
Author
|
Looks like Reader is using Moment.js for it's transformation of time duration into a localized string. |
Contributor
Author
|
Just updated the localized strings so the order of the parameters is able to be changed. Thanks @sendhil! |
astralbodies
added a commit
that referenced
this pull request
Mar 20, 2014
…ring-i18n Switched to NSDateComponents to create the date "short string"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #583
This change also allows for localization of the units of time single characters. NSDateComponents seems to perform well enough during scrolling - CALayer stuff swamped the CPU comparatively during instrumentation.