Add classic editor deprecation notice#16008
Merged
Conversation
|
You can trigger an installable build for these changes by visiting CircleCI here. |
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
added 9 commits
March 4, 2021 14:03
The classic editor is now deprecated and a notice has been added to it to communicate this.
Added persistence flag to make the notice be shown only once per install, and only on empty posts.
cameronvoell
approved these changes
Mar 5, 2021
Contributor
cameronvoell
left a comment
cameronvoell
left a comment
There was a problem hiding this comment.
Changes look good. Notice looks good in dark mode. I did not see it come up after the initial presentation, worked as expected 👍
3 tasks
guarani
pushed a commit
to wordpress-mobile/WordPressMocks
that referenced
this pull request
Mar 18, 2021
The [classic editor is deprecated](wordpress-mobile/WordPress-iOS#16008) and is [now being removed](wordpress-mobile/WordPress-iOS#15766) for Simple sites (except when editing existing posts with classic content or when using the iOS share extension). This means that on Simple sites, the site settings screen will no longer have a "Enable block editor" switch. WPiOS has a UI test suite, `EditorAztecTests`, that runs on a mock Simple site ("Tri-County Real Estate") and tests various features of the classic editor. Since the classic editor is going away for Simple sites, I think it makes sense to make `EditorAztecTests` run on an Atomic site instead of a Simple site. On WPiOS, this mock site is used for all other UI tests, so this has the side-effect of switching all WPiOS UI tests to run on a mock Atomic site instead of a mock Simple site. The same could be true for WPAndroid and the same considerations might apply.
This was referenced Mar 18, 2021
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses wordpress-mobile/gutenberg-mobile#3209
This PR adds a deprecation notice to the classic editor for all users regardless of site type.
To test
Screenshot
PR submission checklist:
RELEASE-NOTES.txtif necessary.