Dismiss alert in UI tests to ensure tests pass the first time around#16118
Merged
Dismiss alert in UI tests to ensure tests pass the first time around#16118
Conversation
The new classic editor deprecation alert in Aztec (classic editor) is shown only once and was making all UI tests fail on the first try. CircleCI then ran tests a second time and because the alert is not shown again (a flag is persisted to the device to ensure this), tests passed the second time around.
|
You can trigger an installable build for these changes by visiting CircleCI here. |
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
Contributor
Author
|
Thanks @jkmassel! |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new classic editor deprecation alert in Aztec (classic editor) was making all UI tests fail on the first try. CircleCI then ran tests a second time and because the alert is not shown again (state is persisted on the device), tests passed the second time around.
This was causing UI tests to fail the first time around for the last 10 days: https://app.circleci.com/pipelines/github/wordpress-mobile/WordPress-iOS?branch=develop. Since tests always passed the second time, this went unnoticed.
To test:
PR submission checklist:
RELEASE-NOTES.txtif necessary.