Improved QuickPicturePreviewView#2
Closed
mgcm wants to merge 6 commits intowordpress-mobile:masterfrom
mgcm:quickpreview
Closed
Improved QuickPicturePreviewView#2mgcm wants to merge 6 commits intowordpress-mobile:masterfrom mgcm:quickpreview
mgcm wants to merge 6 commits intowordpress-mobile:masterfrom
mgcm:quickpreview
Conversation
…eview extended QuickPicturePreview to toggle the paper clip and borders on and off.
…nge handlers to postsettingsviewcontroller
added zoom out to scale x1 factor if another double tap is performed in the zoomed scrollview
…icturePreviewView
Contributor
There was a problem hiding this comment.
Adding subviews directly to the application window is a curious choice. Going down this road means you loose a lot of the view handling that is just automatic when working with the existing view hierarchy, e.g. orientation changes. I'd like to know a little more about why you made this decision.
Author
There was a problem hiding this comment.
a lot has to do with me looking at how MTZoomWindow works and going down a similar path. another way, I guess, would be getting the topmost ViewController and go from there. would you suggest that approach instead?
roundhill
added a commit
that referenced
this pull request
May 22, 2013
WPTableViewController-based Notifications list
koke
added a commit
that referenced
this pull request
Jul 16, 2013
Added stats for Google Plus sharing.
jleandroperez
added a commit
that referenced
this pull request
Jul 24, 2014
chaitanyapandit
added a commit
to chaitanyapandit/WordPress-iOS
that referenced
this pull request
Dec 15, 2015
- Create RemoteMedia objects for attachments we get from the reader feed. - Added an 'attachments' property (NSArray) to RemoteReaderPost that contains RemoteMedia objects that we create in step wordpress-mobile#1. - wordpress-mobile#1 and wordpress-mobile#2 are done in ReaderPostServiceRemote. - Added a relationship 'attachments' to ReaderPost that points to Media objects. - Implemented a method createOrReplaceFromRemoteAttachments: forPost: in ReaderPostService that creates Media objects from the RemoteMedia objects and links them to the ReaderPost.
frosty
added a commit
that referenced
this pull request
Mar 10, 2017
…sharing Media Library #2: Media URL sharing
This was referenced Jul 30, 2018
3 tasks
kean
added a commit
that referenced
this pull request
Jun 19, 2023
…re-uittype-apis Drop iOS 14 Support: Update UTType usages (#2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QuickPicturePreviewView now behaves more like a normal image viewer, with zooming, scrolling and gestures. QuickPhotoViewController and PostSettingsViewController were changed to reflect the new behaviour.