Skip to content

Add alert dismiss to all Aztec UI tests#16121

Merged
guarani merged 2 commits intodevelopfrom
fix-all-uitest-alerts
Mar 18, 2021
Merged

Add alert dismiss to all Aztec UI tests#16121
guarani merged 2 commits intodevelopfrom
fix-all-uitest-alerts

Conversation

@guarani
Copy link
Contributor

@guarani guarani commented Mar 17, 2021

A follow-up to #16118 to make all Aztec UI tests dismiss the "classic editor deprecation" alert. Otherwise tests will fail if testBasicPostPublish is not run before the other tests. (Although this doesn't happen at the moment since Xcode runs tests in alphabetical order, it might happen if tests are renamed/removed/etc.)

To test:

  1. (Optional) On a clean simulator (without WordPress installed), checkout this branch and run only the testTextPostPublish test, ensure it passes
  2. Run optional UI tests (on any device) and make sure they pass (I've done this below)
  3. Check The Run UI Tests job and make sure tests passed on the first run

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

A follow-up to #15766 to add the dismiss alert call to the other Aztec test. Otherwise tests could break if `testBasicPostPublish` is not run before `testTextPostPublish`.
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Mar 17, 2021

You can trigger an installable build for these changes by visiting CircleCI here.

@guarani guarani added the Testing Unit and UI Tests and Tooling label Mar 17, 2021
@guarani guarani added this to the 17.0 milestone Mar 17, 2021
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Mar 17, 2021

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@guarani guarani changed the title Add missing alert dismiss to UI tests Add alert dismiss to all Aztec UI tests Mar 18, 2021
@guarani guarani requested a review from jkmassel March 18, 2021 00:49
@guarani
Copy link
Contributor Author

guarani commented Mar 18, 2021

Hey @jkmassel, sorry for another PR review. This is fixes an oversight in the previous PR you reviewed for me.

@guarani
Copy link
Contributor Author

guarani commented Mar 18, 2021

I checked all the test steps above, so it might not be necessary to test this locally yourself.

Copy link
Contributor

@jkmassel jkmassel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it locally because I didn't see your comment before I did 😅

:shipit:

@guarani guarani merged commit 2ea3e19 into develop Mar 18, 2021
@guarani guarani deleted the fix-all-uitest-alerts branch March 18, 2021 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Testing Unit and UI Tests and Tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants