Add alert dismiss to all Aztec UI tests#16121
Merged
Conversation
A follow-up to #15766 to add the dismiss alert call to the other Aztec test. Otherwise tests could break if `testBasicPostPublish` is not run before `testTextPostPublish`.
|
You can trigger an installable build for these changes by visiting CircleCI here. |
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
Contributor
Author
|
Hey @jkmassel, sorry for another PR review. This is fixes an oversight in the previous PR you reviewed for me. |
Contributor
Author
|
I checked all the test steps above, so it might not be necessary to test this locally yourself. |
jkmassel
approved these changes
Mar 18, 2021
Contributor
jkmassel
left a comment
There was a problem hiding this comment.
Tested it locally because I didn't see your comment before I did 😅
![]()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A follow-up to #16118 to make all Aztec UI tests dismiss the "classic editor deprecation" alert. Otherwise tests will fail if
testBasicPostPublishis not run before the other tests. (Although this doesn't happen at the moment since Xcode runs tests in alphabetical order, it might happen if tests are renamed/removed/etc.)To test:
testTextPostPublishtest, ensure it passesPR submission checklist:
RELEASE-NOTES.txtif necessary.