Convert UI tests screens to be ScreenObject subclasses – Part 4 of many

[mokagio]

See #17221, #17348, and #17359.

I made this on top of #17359 for ease of review.

Regression Notes

1. Potential unintended areas of impact
   N.A.

2. What I did to test those areas of impact (or what existing automated tests I relied on)
   N.A.

3. What automated tests I added (or what prevented me from doing so)
   N.A.

---

• I have completed the Regression Notes.
• I have considered adding unit tests for my changes. N.A.
• I have considered adding accessibility improvements for my changes. N.A.
• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary. N.A.

[peril-wordpress-mobile]

You can trigger an installable build for these changes by visiting CircleCI here.

[peril-wordpress-mobile]

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

[mokagio]

You might notice that this code is part of BaseScreen, which this train of work aims to remove.

This change here moved the logic to a dedicated extension (feb932e) so that both BaseScreen and ScreenObject could share it in the context of this project.

Better than copy-pasting, in particular because this code is fit to live in the XCUITestHelpers project.

[pachlava]

A question not related to the code affected by PR - is using Xcode 13 now mandatory?

I'm seeing these, which, I suppose, have something to do with me still using 12.5.1:

EDIT: the error is gone after updating to Xcode 13 and using iOS 15.

[pachlava]

Not a part of this PR: it looks like switching to Xcode 13 (and iOS 15) slows down the tests dramatically. Latest execution while still using Xcode 12.5.1 took 557 seconds, while the next already using Xcode 13.0 takes 956 😢 . On the surface it looks like there's an extra delay between all events (key presses, taps, assertions). This is what I mean (my local Xcode 13.1 + iOS 15):

Screen.Recording.2021-11-15.at.17.40.00.mov

I'm installing Simulator 14.5 (which was lost during update) to see if the slowness is related to Xcode or to iOS version.

[pachlava]

Using Xcode 13.1 in combination with iOS 14.5 solves the speed issue.

I found the similar report here (it's an Appium repo, but the root cause is in XCTest). According to one comment from there, the issue also gets fixed in iOS 15.2 (available with code 13.2 which is still beta).

[pachlava]

I executed the tests on iPhone 12 (first with iOS 15, then with 14.5) - they passed. The changes in all files made sense to me and I noticed no issues 👍 Thank you, @mokagio !

[mokagio]

Thanks @pachlava!

I might try Xcode 13.2 beta and see how it compares 🤞