Test PR to verify isFullyVisibleOnScreen removal#17628
Test PR to verify isFullyVisibleOnScreen removal#17628
isFullyVisibleOnScreen removal#17628Conversation
|
You can trigger an installable build for these changes by visiting CircleCI here. |
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
| var iteration = 0 | ||
|
|
||
| while !isFullyVisibleOnScreen && iteration < threshold { | ||
| while isFullyVisibleOnScreen() && iteration < threshold { |
There was a problem hiding this comment.
I know this is the test PR, but was this logic change intentional? !isFullyVisibleOnScreen -> isFullyVisibleOnScreen()
I would expect some tests failing because of that, but I remember seeing cases where isFullyVisibleOnScreen returned true for an element that was partially visible. 🤔
There was a problem hiding this comment.
Great catch @tiagomar! This is purely a mistake on my end.
This actually made me smile because I left a comment earlier on !foo vs foo == false and how ! can be missed, which is exactly the error I made here. Case in point, I guess 🙃
I will fix it anyway, because I plan to cherrypick this commit in the PR that will update XCUITestHelper to a the new version once HACK week is done 👍
mokagio
force-pushed
the
is-fully-visible-on-screen
branch
from
937369e to
e71a109
Compare
|
Closing in favor of #17691 |
2 participants
No description provided.