Upgrade XCUITestHelpers from version 0.3.0 to 0.4.0#17691
Merged
Conversation
Remove custom code, now part of the library: - `isFullyVisibleOnScreen` - `XCUIElement` "wait-for-predicate" extension
|
You can trigger an installable build for these changes by visiting CircleCI here. |
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
jostnes
approved these changes
Dec 21, 2021
Contributor
jostnes
left a comment
jostnes
left a comment
There was a problem hiding this comment.
Looks good! No issues when tested locally and CI tests looks to be passing as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes custom code, now part of the library:
isFullyVisibleOnScreenXCUIElement"wait-for-predicate" extensionRegression Notes
Potential unintended areas of impact
UI tests.
What I did to test those areas of impact (or what existing automated tests I relied on)
I tested the changes in isolation during the XCUITestHelpers work:
isFullyVisibleOnScreenhelper onXCUIElementAutomattic/XCUITestHelpers#5XCUIElementhelper methods to wait for anNSPredicateAutomattic/XCUITestHelpers#6Plus, run UI tests in both CIs for this PR
N.A.
RELEASE-NOTES.txtif necessary. N.A.