Skip to content

Jetpack Switch prompt: fix typo#20009

Merged
twstokes merged 1 commit intowordpress-mobile:trunkfrom
jeherve:jeherve-patch-1
Jan 27, 2023
Merged

Jetpack Switch prompt: fix typo#20009
twstokes merged 1 commit intowordpress-mobile:trunkfrom
jeherve:jeherve-patch-1

Conversation

@jeherve
Copy link
Contributor

@jeherve jeherve commented Jan 26, 2023

That's a small change, so I haven't really done any testing, sorry! This should fix this typo:

Props @codebykat for finding this!

To test:

See the following screen in the app.

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Co-authored-by: Kat Hagan <kat@codebykat.com>
Copy link
Contributor

@twstokes twstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jeherve and @codebykat! I've pushed up a separate branch to run CI and will get this merged. 🙇

@twstokes twstokes enabled auto-merge January 27, 2023 01:22
@twstokes twstokes merged commit 0e45ee0 into wordpress-mobile:trunk Jan 27, 2023
@hassaanelgarem
Copy link
Contributor

@twstokes As far as I understand, this change won't trigger an update to the Localizable.strings file since we didn't change the key. I think we need to update the key to trigger retranslation or directly update the English Localizable.strings file with the new value since the typo shouldn't alter the translated strings anyway.

@mokagio Please correct me if I'm wrong 🙏

@twstokes
Copy link
Contributor

Good call @hassaanelgarem! I overlooked this and thought since it landed in trunk it would get sorted, but didn't consider the key staying the same. Thanks for catching this before the code freeze.

@twstokes
Copy link
Contributor

I've added #20029. Feel free to correct, iterate on, or close it if it's not useful.

@mokagio
Copy link
Contributor

mokagio commented Jan 30, 2023

@twstokes , @hassaanelgarem :

As far as I understand, this change won't trigger an update to the Localizable.strings file since we didn't change the key.

Changing the value of a localized string in the code will result in its .strings definition to change as well. This can be verified by running bundle exec fastlane generate_strings_file_for_glotpress on top of this branch.

image

Commit with the result

So, we're good and no additional change is necessary. 😄

I'd still like to thanks you folks for being mindful of the end-to-end translation process. It really helps 🙇‍♂️ 🙇‍♂️ 🙇‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants