Remove a couple of duplicated localization keys#20030
Merged
Conversation
…ryView` `bundle exec fastlane generate_strings_file_for_glotpress` picked this up: ``` [16:01:52]: ------------------------------------------------- [16:01:52]: --- Step: ios_generate_strings_file_from_code --- [16:01:52]: ------------------------------------------------- [16:01:54]: ▸ Key "jetpack.fullscreen.overlay.newUsers.stats.subtitle" used with multiple values. Value "Watch your traffic grow with helpful insights and comprehensive stats." kept. Value "Find and follow your favorite sites and communities, and share you content." ignored. [16:01:54]: ▸ Key "jetpack.fullscreen.overlay.newUsers.stats.subtitle" used with multiple values. Value "Watch your traffic grow with helpful insights and comprehensive stats." kept. Value "Get notifications for new comments, likes, views, and more." ignored. [16:01:55]: ▸ Key "widget.today.nodata.view.title" used with multiple values. Value "Unable to load site stats." kept. Value "Unable to load today's stats." ignored. ```
`bundle exec fastlane generate_strings_file_for_glotpress` picked this up ``` [16:01:52]: ------------------------------------------------- [16:01:52]: --- Step: ios_generate_strings_file_from_code --- [16:01:52]: ------------------------------------------------- [16:01:54]: ▸ Key "jetpack.fullscreen.overlay.newUsers.stats.subtitle" used with multiple values. Value "Watch your traffic grow with helpful insights and comprehensive stats." kept. Value "Find and follow your favorite sites and communities, and share you content." ignored. [16:01:54]: ▸ Key "jetpack.fullscreen.overlay.newUsers.stats.subtitle" used with multiple values. Value "Watch your traffic grow with helpful insights and comprehensive stats." kept. Value "Get notifications for new comments, likes, views, and more." ignored. [16:01:55]: ▸ Key "widget.today.nodata.view.title" used with multiple values. Value "Unable to load site stats." kept. Value "Unable to load today's stats." ignored. ```
mokagio
commented
Jan 30, 2023
| comment: "Title of the no site view in all time widget") | ||
|
|
||
| static let noSiteViewThisWeekTitle = AppLocalizedString("widget.thisweek.nosite.view.titlee", | ||
| static let noSiteViewThisWeekTitle = AppLocalizedString("widget.thisweek.nosite.view.title", |
Contributor
Author
There was a problem hiding this comment.
This is a typo fix, which I noticed by chance. We don't yet have tooling to spot this minor issues 😅
Contributor
You can test the changes in WordPress from this Pull Request by:
|
Contributor
You can test the changes in Jetpack from this Pull Request by:
|
staskus
approved these changes
Jan 30, 2023
Contributor
staskus
left a comment
There was a problem hiding this comment.
Thanks for the fixes 🙏. I ran the given tests and can verify the behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed these while testing the changes from #20009. Or rather,
bundle exec fastlane generate_strings_file_for_glotpressnoticed these:Testing
Checkout this branch, run
bundle exec fastlane generate_strings_file_for_glotpress skip_commit:trueand verify it prints no warnings:The diff will also show entries for the de-duplicated keys in
Localizable.strings, but it will be tricky to spot them in between all the new strings. A way to verify this would be:trunkbundle exec fastlane generate_strings_file_for_glotpressbundle exec fastlane generate_strings_file_for_glotpress skip_commit:trueagainHowever, our automation is tried and tested and I didn't feel the need to got to such length to verify it.
Regression Notes
RELEASE-NOTES.txtif necessary. N.A.