Skip to content

Drop iOS 14 Support: Replace deprecated UTType APIs in Media#20887

Merged
kean merged 2 commits intotrunkfrom
task/ios-15-uttype
Jun 16, 2023
Merged

Drop iOS 14 Support: Replace deprecated UTType APIs in Media#20887
kean merged 2 commits intotrunkfrom
task/ios-15-uttype

Conversation

@kean
Copy link
Contributor

@kean kean commented Jun 15, 2023

Related Issue #20860

This is a straightforward change that replaces APIs deprecated in iOS 15 with their direct replacements.

To test:

My main way to test it was by writing unit tests (prior to making a change), but I also tested it by checking media uploads from the app.

  • Create a post
  • Upload image/video/document
  • Verify that upload worked
  • Set breakpoint in MediaService.swift line 648 and verify that remoteMedia.mimeType is set according to the uploaded file

Regression Notes

  1. Potential unintended areas of impact: media uploads
  2. What I did to test those areas of impact (or what existing automated tests I relied on): manual testing, automated testing
  3. What automated tests I added (or what prevented me from doing so): every changes was covered by tests

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@kean kean added this to the Pending milestone Jun 15, 2023
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jun 15, 2023

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr20887-567e627
Version22.6
Bundle IDcom.jetpack.alpha
Commit567e627
App Center Buildjetpack-installable-builds #5035
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jun 15, 2023

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr20887-567e627
Version22.6
Bundle IDorg.wordpress.alpha
Commit567e627
App Center BuildWPiOS - One-Offs #6009
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@kean kean force-pushed the task/ios-15-uttype branch from 511ab1f to 567e627 Compare June 15, 2023 21:23
Copy link
Contributor

@momo-ozawa momo-ozawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, works as described!

@momo-ozawa
Copy link
Contributor

@kean I made a new "Drop iOS 14 support" and applied it to all relevant PRs

@kean
Copy link
Contributor Author

kean commented Jun 16, 2023

Thanks, appreciate it, @momo-ozawa!

@kean kean merged commit 239ae62 into trunk Jun 16, 2023
@kean kean deleted the task/ios-15-uttype branch June 16, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants